linux-kernel - Re: [PATCH v2] zram: don't retry compress incompressible page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YwcrpdA0ppFR2i8S@google.com>
Date:   Thu, 25 Aug 2022 16:58:29 +0900
From:   Sergey Senozhatsky <senozhatsky@...omium.org>
To:     Andrew Morton <akpm@...ux-foundation.org>,
        Alexey Romanov <avromanov@...rdevices.ru>
Cc:     minchan@...nel.org, senozhatsky@...omium.org, ngupta@...are.org,
        akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, kernel@...rdevices.ru,
        Dmitry Rokosov <ddrokosov@...rdevices.ru>
Subject: Re: [PATCH v2] zram: don't retry compress incompressible page

On (22/08/24 14:31), Alexey Romanov wrote:
> It doesn't make sense for us to retry to compress an uncompressible
> page (comp_len == PAGE_SIZE) in zsmalloc slowpath, because we will
> be storing it uncompressed anyway. We can avoid wasting time on
> another compression attempt. It is enough to take lock
> (zcomp_stream_get) and execute the code below.
> 
> Signed-off-by: Alexey Romanov <avromanov@...rdevices.ru>
> Signed-off-by: Dmitry Rokosov <ddrokosov@...rdevices.ru>

Reviewed-by: Sergey Senozhatsky <senozhatsky@...omium.org>