linux-kernel - Re: [PATCH 1/1] HID: steam: Prevent NULL pointer dereference in steam_{recv,send}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2208251022170.19850@cbobk.fhfr.pm>
Date:   Thu, 25 Aug 2022 10:22:35 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Lee Jones <lee.jones@...aro.org>
cc:     linux-kernel@...r.kernel.org,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org
Subject: Re: [PATCH 1/1] HID: steam: Prevent NULL pointer dereference in
 steam_{recv,send}_report

On Fri, 8 Jul 2022, Lee Jones wrote:

> It is possible for a malicious device to forgo submitting a Feature
> Report.  The HID Steam driver presently makes no prevision for this
> and de-references the 'struct hid_report' pointer obtained from the
> HID devices without first checking its validity.  Let's change that.
> 
> Cc: Jiri Kosina <jikos@...nel.org>
> Cc: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> Cc: linux-input@...r.kernel.org
> Fixes: c164d6abf3841 ("HID: add driver for Valve Steam Controller")
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Sorry for the delay, I had some time off and things got stalled. Applied 
now, thank you.

-- 
Jiri Kosina
SUSE Labs