linux-kernel - Re: [PATCH -next 2/2] crypto: crc32c - add missing Kconfig option select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ywc36LxM2+0eqKu2@gondor.apana.org.au>
Date:   Thu, 25 Aug 2022 16:50:48 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Gaosheng Cui <cuigaosheng1@...wei.com>
Cc:     davem@...emloft.net, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next 2/2] crypto: crc32c - add missing Kconfig option
 select

On Thu, Aug 25, 2022 at 04:41:38PM +0800, Gaosheng Cui wrote:
> The CRYPTO_CRC32C is using functions provided by CRYPTO_MANAGER,
> otherwise the following error will occur:
> 
>     EXT4-fs (mmcblk0): Cannot load crc32c driver.
> 
> So select CRYPTO_MANAGER when enable CRYPTO_CRC32C.
> 
> Signed-off-by: Gaosheng Cui <cuigaosheng1@...wei.com>
> ---
>  crypto/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/crypto/Kconfig b/crypto/Kconfig
> index b1ccf873779d..7f124604323b 100644
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -641,6 +641,7 @@ config CRYPTO_CRC32C
>  	tristate "CRC32c CRC algorithm"
>  	select CRYPTO_HASH
>  	select CRC32
> +	select CRYPTO_MANAGER
>  	help
>  	  Castagnoli, et al Cyclic Redundancy-Check Algorithm.  Used
>  	  by iSCSI for header and data digests and by others.

Why exactly does it need CRYPTO_MANAGER?

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt