linux-kernel - Re: [RFC/RFT v5 2/4] mac80211: add periodic monitor for channel busy time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3361036446058fe386634a9016c6925146a078e.camel@sipsolutions.net>
Date:   Thu, 25 Aug 2022 10:58:05 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Baligh Gasmi <gasmibal@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Felix Fietkau <nbd@....name>,
        Toke Hoiland-Jorgensen <toke@...hat.com>,
        Linus Lussing <linus.luessing@...3.blue>,
        Kalle Valo <kvalo@...nel.org>
Subject: Re: [RFC/RFT v5 2/4] mac80211: add periodic monitor for channel
 busy time

On Tue, 2022-07-19 at 14:35 +0200, Baligh Gasmi wrote:
> Add a worker scheduled periodicaly to calculate the busy time average of
> the current channel.
> 
> This will be used in the estimation for expected throughput.
> 

I really don't think you should/can do this - having a 1-second periodic
timer (for each interface even!) is going to be really bad for power
consumption.

Please find a way to inline the recalculation with statistics updates
and/or queries.

johannes