linux-kernel - Re: [PATCH] EDAC,wq: remove unneeded flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ywc5p1lFSPsyY/cV@zn.tnic>
Date:   Thu, 25 Aug 2022 10:58:15 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     cgel.zte@...il.com
Cc:     mchehab@...nel.org, tony.luck@...el.com, james.morse@....com,
        rric@...nel.org, linux-edac@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        ran jianping <ran.jianping@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] EDAC,wq: remove unneeded flush_workqueue

On Sun, Apr 24, 2022 at 06:21:26AM +0000, cgel.zte@...il.com wrote:
> From: ran jianping <ran.jianping@....com.cn>
> 
> All work currently pending will be done first by calling destroy_workqueue,
> so there is no need to flush it explicitly.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: ran jianping <ran.jianping@....com.cn>
> ---
>  drivers/edac/wq.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/edac/wq.c b/drivers/edac/wq.c
> index d021d287eaec..ad3f516627c5 100644
> --- a/drivers/edac/wq.c
> +++ b/drivers/edac/wq.c
> @@ -37,7 +37,6 @@ int edac_workqueue_setup(void)
>  
>  void edac_workqueue_teardown(void)
>  {
> -	flush_workqueue(wq);
>  	destroy_workqueue(wq);
>  	wq = NULL;
>  }
> -- 

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette