linux-kernel - Re: [PATCH] HID: cp2112: Remove some dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2208251126010.19850@cbobk.fhfr.pm>
Date:   Thu, 25 Aug 2022 11:26:39 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-input@...r.kernel.org
Subject: Re: [PATCH] HID: cp2112: Remove some dead code

On Sat, 18 Jun 2022, Christophe JAILLET wrote:

> Commit 13de9cca514e ("HID: cp2112: add IRQ chip handling") has introduced
> cp2112_allocate_irq() that seems to be unused since 2016.
> 
> Remove it, remove the associated resources and part of the remove()
> function that frees the resources allocated in cp2112_allocate_irq().
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> Compile tested only.
> 
> Maybe the issue is completely elsewhere and the probe() should call
> cp2112_allocate_irq() in some cases.

Benjamin, could you please take a look? Apparently you were aware of the 
code being dead due to the __maybe_unused annotation ... :) What was the 
point?

Thanks,

-- 
Jiri Kosina
SUSE Labs