linux-kernel - Re: [PATCH] dt-bindings: power: Add missing (unevaluated|additional)Properties on child nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFriYXh2EwqyPH7MMbt-2FAYZFrBhNFTFvNrPn=W_5VEKg@mail.gmail.com>
Date:   Thu, 25 Aug 2022 11:51:08 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Andrey Smirnov <andrew.smirnov@...il.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] dt-bindings: power: Add missing (unevaluated|additional)Properties
 on child nodes

On Tue, 23 Aug 2022 at 16:57, Rob Herring <robh@...nel.org> wrote:
>
> In order to ensure only documented properties are present, node schemas
> must have unevaluatedProperties or additionalProperties set to false
> (typically).
>
> Signed-off-by: Rob Herring <robh@...nel.org>

Acked-by: Ulf Hansson <ulf.hansson@...aro.org>

Kind regards
Uffe

> ---
>  .../bindings/power/domain-idle-state.yaml          | 10 ++++++++++
>  .../devicetree/bindings/power/fsl,imx-gpc.yaml     | 14 ++++++++++++++
>  .../devicetree/bindings/power/fsl,imx-gpcv2.yaml   | 14 ++++++++++++++
>  3 files changed, 38 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/domain-idle-state.yaml b/Documentation/devicetree/bindings/power/domain-idle-state.yaml
> index 6a12efdf436a..4ee920a1de69 100644
> --- a/Documentation/devicetree/bindings/power/domain-idle-state.yaml
> +++ b/Documentation/devicetree/bindings/power/domain-idle-state.yaml
> @@ -20,6 +20,7 @@ properties:
>  patternProperties:
>    "^(cpu|cluster|domain)-":
>      type: object
> +    additionalProperties: false
>      description:
>        Each state node represents a domain idle state description.
>
> @@ -44,6 +45,15 @@ patternProperties:
>            state will yield power benefits, after overcoming the overhead while
>            entering the idle state.
>
> +      arm,psci-suspend-param:
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        description: |
> +          power_state parameter to pass to the ARM PSCI suspend call.
> +
> +          Device tree nodes that require usage of PSCI CPU_SUSPEND function
> +          (i.e. idle states node with entry-method property is set to "psci")
> +          must specify this property.
> +
>      required:
>        - compatible
>        - entry-latency-us
> diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml b/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
> index a055b3e819d8..777e1d852ddd 100644
> --- a/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
> +++ b/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
> @@ -43,11 +43,21 @@ properties:
>
>    pgc:
>      type: object
> +    additionalProperties: false
>      description: list of power domains provided by this controller.
>
> +    properties:
> +      '#address-cells':
> +        const: 1
> +
> +      '#size-cells':
> +        const: 0
> +
>      patternProperties:
>        "power-domain@[0-9]$":
>          type: object
> +        additionalProperties: false
> +
>          properties:
>
>            '#power-domain-cells':
> @@ -78,6 +88,10 @@ properties:
>            - '#power-domain-cells'
>            - reg
>
> +    required:
> +      - '#address-cells'
> +      - '#size-cells'
> +
>  required:
>    - compatible
>    - reg
> diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml
> index 747622bdc57b..3b161e01f920 100644
> --- a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml
> +++ b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml
> @@ -42,11 +42,21 @@ properties:
>
>    pgc:
>      type: object
> +    additionalProperties: false
>      description: list of power domains provided by this controller.
>
> +    properties:
> +      '#address-cells':
> +        const: 1
> +
> +      '#size-cells':
> +        const: 0
> +
>      patternProperties:
>        "power-domain@[0-9]$":
>          type: object
> +        additionalProperties: false
> +
>          properties:
>
>            '#power-domain-cells':
> @@ -85,6 +95,10 @@ properties:
>            - '#power-domain-cells'
>            - reg
>
> +    required:
> +      - '#address-cells'
> +      - '#size-cells'
> +
>  required:
>    - compatible
>    - reg
> --
> 2.34.1
>