linux-kernel - Re: [PATCH v2] drivers/virt/vSMP: new driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220825104604.GD2030@kadam>
Date:   Thu, 25 Aug 2022 13:46:04 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     "Czerwacki, Eial" <eial.czerwacki@....com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Arsh, Leonid" <leonid.arsh@....com>,
        "Twaig, Oren" <oren.twaig@....com>,
        SAP vSMP Linux Maintainer <linux.vsmp@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arnd Bergmann <arnd@...db.de>,
        Andra Paraschiv <andraprs@...zon.com>,
        Borislav Petkov <bp@...e.de>,
        Brijesh Singh <brijesh.singh@....com>,
        Eric Biggers <ebiggers@...gle.com>, Fei Li <fei1.li@...el.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Jens Axboe <axboe@...nel.dk>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Subject: Re: [PATCH v2] drivers/virt/vSMP: new driver

On Thu, Aug 25, 2022 at 06:24:02AM +0000, Czerwacki, Eial wrote:
> Introducing the vSMP guest driver which allows interaction with the
> vSMP control device when running a Linux OS atop of the vSMP hypervisor.
> vSMP is a resource aggregation hypervisor from SAP.
> 
> The driver comprises of api part which facilitates communication with
> the hypervisor and version which displays the hypervisor's version.
> 
> This patch s based on previous patches sent to the staging tree mailing
> lists
> 
> Signed-off-by: Eial Czerwacki <eial.czerwacki@....com>
> Acked-by: Leonid Arsh <leonid.arsh@....com>
> Acked-by: Oren Twaig <oren.twaig@....com>
> CC: SAP vSMP Linux Maintainer <linux.vsmp@....com>
> CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> CC: Arnd Bergmann <arnd@...db.de>
> CC: Dan Carpenter <dan.carpenter@...cle.com>
> CC: Andra Paraschiv <andraprs@...zon.com>
> CC: Borislav Petkov <bp@...e.de>
> CC: Brijesh Singh <brijesh.singh@....com>
> CC: Eric Biggers <ebiggers@...gle.com>
> CC: Fei Li <fei1.li@...el.com>
> CC: Hans de Goede <hdegoede@...hat.com>
> CC: Jens Axboe <axboe@...nel.dk>
> CC: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> 
> v1 -> v2:
> 	- fix -0 var init in add_sysfs_entries (pointed out by Dan Carpenter)

Please don't resend patches the same day.  Always wait at least a day
but probably for a new driver wait 3 days.  There are going to be a lot
of comments on this.

My comment didn't even warrant a resend at all, it just something that
made me chuckle.  It will take a while to review this properly.

regards,
dan carpenter