linux-kernel - Re: [PATCH 5.19] mt76: mt7921: fix command timeout in AP stop period

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YwdkCRXdOZCTdPQl@kroah.com>
Date:   Thu, 25 Aug 2022 13:59:05 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     sean.wang@...iatek.com
Cc:     stable@...r.kernel.org, linux-wireless@...r.kernel.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Deren Wu <deren.wu@...iatek.com>, Felix Fietkau <nbd@....name>
Subject: Re: [PATCH 5.19] mt76: mt7921: fix command timeout in AP stop period

On Thu, Aug 25, 2022 at 11:27:22AM +0800, sean.wang@...iatek.com wrote:
> From: Deren Wu <deren.wu@...iatek.com>
> 
> commit 9d958b60ebc2434f2b7eae83d77849e22d1059eb upstream.
> 
> Due to AP stop improperly, mt7921 driver would face random command timeout
> by chip fw problem. Migrate AP start/stop process to .start_ap/.stop_ap and
> congiure BSS network settings in both hooks.
> 
> The new flow is shown below.
> * AP start
>     .start_ap()
>       configure BSS network resource
>       set BSS to connected state
>     .bss_info_changed()
>       enable fw beacon offload
> 
> * AP stop
>     .bss_info_changed()
>       disable fw beacon offload (skip this command)
>     .stop_ap()
>       set BSS to disconnected state (beacon offload disabled automatically)
>       destroy BSS network resource
> 
> Fixes: 116c69603b01 ("mt76: mt7921: Add AP mode support")
> Signed-off-by: Sean Wang <sean.wang@...iatek.com>
> Signed-off-by: Deren Wu <deren.wu@...iatek.com>
> Signed-off-by: Felix Fietkau <nbd@....name>
> ---
>  .../wireless/mediatek/mt76/mt76_connac_mcu.c  |  2 +
>  .../net/wireless/mediatek/mt76/mt7921/main.c  | 47 +++++++++++++++----
>  .../net/wireless/mediatek/mt76/mt7921/mcu.c   |  5 +-
>  .../wireless/mediatek/mt76/mt7921/mt7921.h    |  2 +
>  4 files changed, 43 insertions(+), 13 deletions(-)

Now queued up, thanks,

greg k-h