linux-kernel - Re: [PATCH v6 1/7] gpio-f7188x: switch over to using pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 25 Aug 2022 14:02:06 +0200
From:   simon.guinot@...uanux.org
To:     Henning Schild <henning.schild@...mens.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Pavel Machek <pavel@....cz>,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <markgross@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Lee Jones <lee@...nel.org>, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org,
        platform-driver-x86@...r.kernel.org,
        Sheng-Yuan Huang <syhuang3@...oton.com>,
        Tasanakorn Phaipool <tasanakorn@...il.com>
Subject: Re: [PATCH v6 1/7] gpio-f7188x: switch over to using pr_fmt

On Thu, Aug 25, 2022 at 12:44:16PM +0200, Henning Schild wrote:
> Subsequent patches will touch that file, apply some nice to have style
> changes before actually adding functional changes.
> 
> Signed-off-by: Henning Schild <henning.schild@...mens.com>

Acked-by: Simon Guinot <simon.guinot@...uanux.org>

> ---
>  drivers/gpio/gpio-f7188x.c | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-f7188x.c b/drivers/gpio/gpio-f7188x.c
> index 18a3147f5a42..fef539bbc03a 100644
> --- a/drivers/gpio/gpio-f7188x.c
> +++ b/drivers/gpio/gpio-f7188x.c
> @@ -7,6 +7,9 @@
>   * Author: Simon Guinot <simon.guinot@...uanux.org>
>   */
>  
> +#define DRVNAME "gpio-f7188x"
> +#define pr_fmt(fmt) DRVNAME ": " fmt
> +
>  #include <linux/module.h>
>  #include <linux/init.h>
>  #include <linux/platform_device.h>
> @@ -14,8 +17,6 @@
>  #include <linux/gpio/driver.h>
>  #include <linux/bitops.h>
>  
> -#define DRVNAME "gpio-f7188x"
> -
>  /*
>   * Super-I/O registers
>   */
> @@ -110,7 +111,7 @@ static inline int superio_enter(int base)
>  {
>  	/* Don't step on other drivers' I/O space by accident. */
>  	if (!request_muxed_region(base, 2, DRVNAME)) {
> -		pr_err(DRVNAME "I/O address 0x%04x already in use\n", base);
> +		pr_err("I/O address 0x%04x already in use\n", base);
>  		return -EBUSY;
>  	}
>  
> @@ -487,7 +488,7 @@ static int __init f7188x_find(int addr, struct f7188x_sio *sio)
>  	err = -ENODEV;
>  	devid = superio_inw(addr, SIO_MANID);
>  	if (devid != SIO_FINTEK_ID) {
> -		pr_debug(DRVNAME ": Not a Fintek device at 0x%08x\n", addr);
> +		pr_debug("Not a Fintek device at 0x%08x\n", addr);
>  		goto err;
>  	}
>  
> @@ -518,13 +519,13 @@ static int __init f7188x_find(int addr, struct f7188x_sio *sio)
>  		sio->type = f81865;
>  		break;
>  	default:
> -		pr_info(DRVNAME ": Unsupported Fintek device 0x%04x\n", devid);
> +		pr_info("Unsupported Fintek device 0x%04x\n", devid);
>  		goto err;
>  	}
>  	sio->addr = addr;
>  	err = 0;
>  
> -	pr_info(DRVNAME ": Found %s at %#x, revision %d\n",
> +	pr_info("Found %s at %#x, revision %d\n",
>  		f7188x_names[sio->type],
>  		(unsigned int) addr,
>  		(int) superio_inb(addr, SIO_DEVREV));
> @@ -548,13 +549,13 @@ f7188x_gpio_device_add(const struct f7188x_sio *sio)
>  	err = platform_device_add_data(f7188x_gpio_pdev,
>  				       sio, sizeof(*sio));
>  	if (err) {
> -		pr_err(DRVNAME "Platform data allocation failed\n");
> +		pr_err("Platform data allocation failed\n");
>  		goto err;
>  	}
>  
>  	err = platform_device_add(f7188x_gpio_pdev);
>  	if (err) {
> -		pr_err(DRVNAME "Device addition failed\n");
> +		pr_err("Device addition failed\n");
>  		goto err;
>  	}
>  
> -- 
> 2.35.1

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)