linux-kernel - Re: [PATCH 1/1] Pinctrl: Add in zero check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdaSv9Haar1jfkZKKxwO+pwNkttSrhN9y_Nn5ODOthBF2Q@mail.gmail.com>
Date:   Thu, 25 Aug 2022 14:19:51 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Will Shiu <Will.Shiu@...iatek.com>, stanley.chu@...iatek.com,
        Matthias Brugger <matthias.bgg@...il.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Mediatek WSD Upstream <wsd_upstream@...iatek.com>
Subject: Re: [PATCH 1/1] Pinctrl: Add in zero check

On Thu, Aug 25, 2022 at 2:18 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Thu, Aug 25, 2022 at 3:07 PM Linus Walleij <linus.walleij@...aro.org> wrote:
> > On Tue, Aug 16, 2022 at 11:09 AM Will Shiu <Will.Shiu@...iatek.com> wrote:
> >
> > > add in check of buffer offset to avoid the exception when input 0 size.
> > >
> > > Signed-off-by: Will Shiu <Will.Shiu@...iatek.com>
> >
> > Looks good to me, patch applied!
>
> Sorry, but it seems the author didn't pay much attention and didn't
> really work on it. What does the < 0 comparison mean here?
>
> I would ask if there is _real_ issue with the code? What is the use
> case and why is this check needed?

Dropped this until Andy's question is answered.

Yours,
Linus Walleij