| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <YweAGTuBw1hWm8PW@B-P7TQMD6M-0146.local>
Date: Thu, 25 Aug 2022 21:58:49 +0800
From: Gao Xiang <hsiangkao@...ux.alibaba.com>
To: Sun Ke <sunke32@...wei.com>,
Dan Carpenter <dan.carpenter@...cle.com>
Cc: JeffleXu <jefflexu@...ux.alibaba.com>,
kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-cachefs@...hat.com, linux-fsdevel@...r.kernel.org
Subject: Re: [Linux-cachefs] [PATCH v3] cachefiles: fix error return code in
cachefiles_ondemand_copen()
On Thu, Aug 25, 2022 at 04:36:20PM +0300, Dan Carpenter wrote:
> I spent a long time looking at this as well... It's really inscrutable
> code. It would be more readable if we just spelled things out in the
> most pedantic way possible:
>
Yeah, the following code looks much better. Ke, would you mind
sending a version like below instead?
Thanks,
Gao Xiang
> diff --git a/fs/cachefiles/ondemand.c b/fs/cachefiles/ondemand.c
> index 1fee702d5529..7e1586bd5cf3 100644
> --- a/fs/cachefiles/ondemand.c
> +++ b/fs/cachefiles/ondemand.c
> @@ -158,9 +158,13 @@ int cachefiles_ondemand_copen(struct cachefiles_cache *cache, char *args)
>
> /* fail OPEN request if daemon reports an error */
> if (size < 0) {
> - if (!IS_ERR_VALUE(size))
> - size = -EINVAL;
> - req->error = size;
> + if (!IS_ERR_VALUE(size)) {
> + req->error = -EINVAL;
> + ret = -EINVAL;
> + } else {
> + req->error = size;
> + ret = 0;
> + }
> goto out;
> }
>
>
> --
> Linux-cachefs mailing list
> Linux-cachefs@...hat.com
> https://listman.redhat.com/mailman/listinfo/linux-cachefs
Powered by blists - more mailing lists