linux-kernel - Re: [PATCH 1/2] um: Cleanup syscall_handler_t cast in syscalls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 26 Aug 2022 13:37:01 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Lukas Straub <lukasstraub2@....de>,
        linux-um <linux-um@...ts.infradead.org>
Cc:     Richard Weinberger <richard@....at>,
        Anton Ivanov <anton.ivanov@...bridgegreys.com>,
        Johannes Berg <johannes@...solutions.net>, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] um: Cleanup syscall_handler_t cast in syscalls_32.h



On 8/26/22 08:29, Lukas Straub wrote:
> Like in f4f03f299a56ce4d73c5431e0327b3b6cb55ebb9
> "um: Cleanup syscall_handler_t definition/cast, fix warning",
> remove the cast to to fix the compiler warning.
> 
> Signed-off-by: Lukas Straub <lukasstraub2@....de>

Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

Thanks.

> ---
>  arch/x86/um/shared/sysdep/syscalls_32.h | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/um/shared/sysdep/syscalls_32.h b/arch/x86/um/shared/sysdep/syscalls_32.h
> index 68fd2cf526fd..f6e9f84397e7 100644
> --- a/arch/x86/um/shared/sysdep/syscalls_32.h
> +++ b/arch/x86/um/shared/sysdep/syscalls_32.h
> @@ -6,10 +6,9 @@
>  #include <asm/unistd.h>
>  #include <sysdep/ptrace.h>
>  
> -typedef long syscall_handler_t(struct pt_regs);
> +typedef long syscall_handler_t(struct syscall_args);
>  
>  extern syscall_handler_t *sys_call_table[];
>  
>  #define EXECUTE_SYSCALL(syscall, regs) \
> -	((long (*)(struct syscall_args)) \
> -	 (*sys_call_table[syscall]))(SYSCALL_ARGS(&regs->regs))
> +	((*sys_call_table[syscall]))(SYSCALL_ARGS(&regs->regs))

-- 
~Randy