[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CADnq5_N+q9=oEYwiYxwRRgYeSfp+XaCxs6fwj9iFJsKhJOL2Tg@mail.gmail.com>
Date: Fri, 26 Aug 2022 16:38:20 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: cgel.zte@...il.com
Cc: alexander.deucher@....com, Jack.Xiao@....com, guchun.chen@....com,
airlied@...ux.ie, Bokun.Zhang@....com,
Zeal Robot <zealci@....com.cn>, Xinhui.Pan@....com,
ricetons@...il.com, linux-kernel@...r.kernel.org,
amd-gfx@...ts.freedesktop.org, Prike.Liang@....com,
dri-devel@...ts.freedesktop.org,
ye xingchen <ye.xingchen@....com.cn>, christian.koenig@....com,
Hawking.Zhang@....com
Subject: Re: [PATCH linux-next] drm/amdgpu: Remove the unneeded result variable
Applied. Thanks!
Alex
On Fri, Aug 26, 2022 at 3:24 AM <cgel.zte@...il.com> wrote:
>
> From: ye xingchen <ye.xingchen@....com.cn>
>
> Return the value sdma_v5_2_start() directly instead of storing it in
> another redundant variable.
>
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@....com.cn>
> ---
> drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c b/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c
> index 83c6ccaaa9e4..95689ef4be10 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c
> @@ -1413,12 +1413,9 @@ static int sdma_v5_2_sw_fini(void *handle)
>
> static int sdma_v5_2_hw_init(void *handle)
> {
> - int r;
> struct amdgpu_device *adev = (struct amdgpu_device *)handle;
>
> - r = sdma_v5_2_start(adev);
> -
> - return r;
> + return sdma_v5_2_start(adev);
> }
>
> static int sdma_v5_2_hw_fini(void *handle)
> --
> 2.25.1
Powered by blists - more mailing lists