linux-kernel - Re: [PATCH v3 1/4] KVM: selftests: Explicitly set variables based on options in dirty_log_perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Aug 2022 14:12:49 -0700
From:   Vipin Sharma <vipinsh@...gle.com>
To:     seanjc@...gle.com, dmatlack@...gle.com, pbonzini@...hat.com
Cc:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/4] KVM: selftests: Explicitly set variables based on
 options in dirty_log_perf_test

On Fri, Aug 26, 2022 at 11:45 AM Vipin Sharma <vipinsh@...gle.com> wrote:
>
> Variable set via -g are also indirectly set by -e option by omitting
> break statement. Set them explicitly so that movement of switch-case
> statements does not unintentionally break features.
>
> No functional change intended.
>
> Signed-off-by: Vipin Sharma <vipinsh@...gle.com>
> ---
>  tools/testing/selftests/kvm/dirty_log_perf_test.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/kvm/dirty_log_perf_test.c b/tools/testing/selftests/kvm/dirty_log_perf_test.c
> index f99e39a672d3..a03db7f9f4c0 100644
> --- a/tools/testing/selftests/kvm/dirty_log_perf_test.c
> +++ b/tools/testing/selftests/kvm/dirty_log_perf_test.c
> @@ -411,6 +411,8 @@ int main(int argc, char *argv[])
>                 case 'e':
>                         /* 'e' is for evil. */
>                         run_vcpus_while_disabling_dirty_logging = true;
> +                       dirty_log_manual_caps = 0;
> +                       break;

@Sean, I hope you intentionally didn't write a break between -e and -g
when you created the patch and it is not just a missed thing :)


>                 case 'g':
>                         dirty_log_manual_caps = 0;
>                         break;
> --
> 2.37.2.672.g94769d06f0-goog
>