linux-kernel - Re: [PATCH] scsi: core: Fix block I/O error of USB card reader during resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ba28a61-0aa2-14d7-61f0-0e9316844f70@acm.org>
Date:   Fri, 26 Aug 2022 15:05:51 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Michael Wu <michael@...winnertech.com>, jejb@...ux.ibm.com,
        martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: core: Fix block I/O error of USB card reader during
 resume

On 8/23/22 03:16, Michael Wu wrote:
> Yes... My patch did seem suspicious. Here's the scene about the block 
> I/O error: Some card reader does not respond the command 'MEDIUM REMOVAL 
> PREVENT' correctly, as a result, the host does not send subsequent cmd 
> 'MEDIUM REMOVAL ALLOW'/'MEDIUM REMOVAL PREVENT' before/after sleep, 
> which leads to a enumeration failure after system resume.
> I wonder, without changing the behavior of the device, is there's a 
> better way to solve this? -- Modifying the scsi core should not be a 
> good idea though :(

The above is not clear to me. My understanding is that "MEDIUM REMOVAL 
PREVENT" is a sense code instead of a SCSI command?

> Thanks for your kindly notice. I looked around in the latest linux 
> mainline repo, but could not find this code. Where can I get this 2002 
> version of scsi_lib.c? Thank you.

Please take a look at 
https://stackoverflow.com/questions/3264283/linux-kernel-historical-git-repository-with-full-history. 
That web page has instructions for how to configure a git repository 
such that history goes back before the time when Linus started using git.

Bart.