linux-kernel - Re: [PATCH] Documentation/mm/page_owner.rst: update experimental data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YwhJDJQkymdN0E2N@kernel.org>
Date:   Fri, 26 Aug 2022 07:16:12 +0300
From:   Mike Rapoport <rppt@...nel.org>
To:     Bagas Sanjaya <bagasdotme@...il.com>
Cc:     Jonathan Corbet <corbet@....net>,
        Yixuan Cao <caoyixuan2019@...il.szu.edu.cn>,
        akpm@...ux-foundation.org, yejiajian2018@...il.szu.edu.cn,
        skhan@...uxfoundation.org, akiyks@...il.com,
        zhangyinan2019@...il.szu.edu.cn, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Documentation/mm/page_owner.rst: update experimental data

On Fri, Aug 26, 2022 at 09:30:46AM +0700, Bagas Sanjaya wrote:
> On Thu, Aug 25, 2022 at 12:09:35PM -0600, Jonathan Corbet wrote:
> > >  - Without page owner::
> > >  
> > >     text    data     bss     dec     hex filename
> > > -   48392   2333     644   51369    c8a9 mm/page_alloc.o
> > > +   58581   3166     652   62399    f3bf mm/page_alloc.o
> > >  
> > >  - With page owner::
> > >  
> > >     text    data     bss     dec     hex filename
> > > -   48800   2445     644   51889    cab1 mm/page_alloc.o
> > > -   6662     108      29    6799    1a8f mm/page_owner.o
> > > -   1025       8       8    1041     411 mm/page_ext.o
> > > +   59085   3294     652   63031    f637 mm/page_alloc.o
> > > +   7464     125      28    7617    1dc1 mm/page_owner.o
> > > +   1396      32       8    1436     59c mm/page_ext.o
> > >  
> > > -Although, roughly, 8 KB code is added in total, page_alloc.o increase by
> > > -520 bytes and less than half of it is in hotpath. Building the kernel with
> > > +Although, roughly, 9 KB code is added in total, page_alloc.o increase by
> > > +632 bytes and less than half of it is in hotpath. Building the kernel with
> > >  page owner and turning it on if needed would be great option to debug
> > >  kernel memory problem.
> > 
> > This seems like a fine patch...but I do have to wonder if it really
> > makes sense to maintain this information, which will surely be subject
> > to frequent change.  Perhaps the whole thing is better replaced with a
> > line saying that enabling page owner adds ~9KB?
> > 
> 
> The size figure above is from size(1) from binutils, for which the
> command is run (maybe) against vmlinux.
> 
> So I would like to say "Enabling page owner increases vmlinux size by
> several kilobytes."

Looks like original text tried to emphasize that there is no significant
change to page allocator code, and I think it's worth keeping it. E.g.
leaving something like

"Although, enabling page owner increases kernel size by several kilobytes,
most of this code is outside page allocator and its hot path."
 
instead of size(1) output and the sentences before and after it.

> Thanks.
> 
> -- 
> An old man doll... just what I always wanted! - Clara



-- 
Sincerely yours,
Mike.