linux-kernel - Re: drivers/soc/mediatek/mtk-svs.c:1287:34: warning: unused variable 'svs_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57b31acfc4f5bcff3c73c35bc30805b84af3bfbd.camel@mediatek.com>
Date:   Fri, 26 Aug 2022 13:38:50 +0800
From:   Roger Lu <roger.lu@...iatek.com>
To:     kernel test robot <lkp@...el.com>
CC:     <llvm@...ts.linux.dev>, <kbuild-all@...ts.01.org>,
        <linux-kernel@...r.kernel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Kevin Hilman <khilman@...libre.com>
Subject: Re: drivers/soc/mediatek/mtk-svs.c:1287:34: warning: unused
 variable 'svs_of_match'

Dear all,

Sorry for late reply. These issues are fixed by below patches. Thanks for the
heads-up.

  drivers/soc/mediatek/mtk-svs.c:1481:12: error: unused function 'svs_suspend'
[-Werror,-Wunused-function]
  static int svs_suspend(struct device *dev)
             ^
  drivers/soc/mediatek/mtk-svs.c:1515:12: error: unused function 'svs_resume' [-
Werror,-Wunused-function]
  static int svs_resume(struct device *dev)

=> fixed by 
https://patchwork.kernel.org/project/linux-mediatek/patch/20220622175649.1856337-1-nathan@kernel.org/

>> drivers/soc/mediatek/mtk-svs.c:1287:34: warning: unused variable
'svs_of_match' [-Wunused-const-variable]
   static const struct of_device_id svs_of_match[] = {

=> fixed by 
https://patchwork.kernel.org/project/linux-mediatek/patch/20220726141653.177948-5-angelogioacchino.delregno@collabora.com/

Sincerely,
Roger Lu.

On Sun, 2022-08-21 at 04:38 +0800, kernel test robot wrote:
> Hi Roger,
> 
> FYI, the error/warning still remains.
> 
> tree:   
> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git__;!!CTRNKA9wMg0ARbw!0KbjAYXXstyhJQ4NbExdZ1NlNqc0lVccMpejf3AQ2614pGuQkpDXre1pRIYXvgh9$
>   master
> head:   cc1807b9158a909ffe829a5e222be756c57c9a90
> commit: 681a02e9500073cd8b9c25a04f06166254b5a879 soc: mediatek: SVS: introduce
> MTK SVS engine
> date:   9 weeks ago
> config: hexagon-randconfig-r022-20220821 (
> https://urldefense.com/v3/__https://download.01.org/0day-ci/archive/20220821/202208210442.ZL8oxHze-lkp@intel.com/config__;!!CTRNKA9wMg0ARbw!0KbjAYXXstyhJQ4NbExdZ1NlNqc0lVccMpejf3AQ2614pGuQkpDXre1pRKmS3VSy$
>  )
> compiler: clang version 16.0.0 (
> https://urldefense.com/v3/__https://github.com/llvm/llvm-project__;!!CTRNKA9wMg0ARbw!0KbjAYXXstyhJQ4NbExdZ1NlNqc0lVccMpejf3AQ2614pGuQkpDXre1pRIUR1DJG$
> $  c9a41fe60ab62f7a40049c100adcc8087a47669b)
> reproduce (this is a W=1 build):
>         wget 
> https://urldefense.com/v3/__https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross__;!!CTRNKA9wMg0ARbw!0KbjAYXXstyhJQ4NbExdZ1NlNqc0lVccMpejf3AQ2614pGuQkpDXre1pRF4kJosK$
>   -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # 
> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=681a02e9500073cd8b9c25a04f06166254b5a879__;!!CTRNKA9wMg0ARbw!0KbjAYXXstyhJQ4NbExdZ1NlNqc0lVccMpejf3AQ2614pGuQkpDXre1pRNjbQMgG$
>  
>         git remote add linus 
> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git__;!!CTRNKA9wMg0ARbw!0KbjAYXXstyhJQ4NbExdZ1NlNqc0lVccMpejf3AQ2614pGuQkpDXre1pRIYXvgh9$
>  
>         git fetch --no-tags linus master
>         git checkout 681a02e9500073cd8b9c25a04f06166254b5a879
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1
> O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/soc/mediatek/
> 
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@...el.com>
> 
> All warnings (new ones prefixed by >>):
> 
>    drivers/soc/mediatek/mtk-svs.c:853:12: warning: unused function
> 'svs_suspend' [-Wunused-function]
>    static int svs_suspend(struct device *dev)
>               ^
>    drivers/soc/mediatek/mtk-svs.c:880:12: warning: unused function
> 'svs_resume' [-Wunused-function]
>    static int svs_resume(struct device *dev)
>               ^
> > > drivers/soc/mediatek/mtk-svs.c:1287:34: warning: unused variable
> > > 'svs_of_match' [-Wunused-const-variable]
> 
>    static const struct of_device_id svs_of_match[] = {
>                                     ^
>    3 warnings generated.
> 
> 
> vim +/svs_of_match +1287 drivers/soc/mediatek/mtk-svs.c
> 
>   1286	
> > 1287	static const struct of_device_id svs_of_match[] = {
> 
>   1288		{
>   1289			.compatible = "mediatek,mt8183-svs",
>   1290			.data = &svs_mt8183_platform_data,
>   1291		}, {
>   1292			/* Sentinel */
>   1293		},
>   1294	};
>   1295	
>