linux-kernel - Re: [RFC PATCH] usb: reduce kernel log spam on driver registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <77d05dac-b4d3-e88f-ecd0-46b6e92fd637@linaro.org>
Date:   Fri, 26 Aug 2022 08:57:02 +0300
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Ard Biesheuvel <ardb@...nel.org>, linux-kernel@...r.kernel.org
Cc:     Alan Stern <stern@...land.harvard.edu>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Avi Fishman <avifishman70@...il.com>,
        Tomer Maimon <tmaimon77@...il.com>,
        Tali Perry <tali.perry1@...il.com>,
        Patrick Venture <venture@...gle.com>,
        Nancy Yuen <yuenn@...gle.com>,
        Benjamin Fair <benjaminfair@...gle.com>,
        Patrice Chotard <patrice.chotard@...s.st.com>,
        Vladimir Zapolskiy <vz@...ia.com>, linux-usb@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [RFC PATCH] usb: reduce kernel log spam on driver registration

On 25/08/2022 20:03, Ard Biesheuvel wrote:
> Drivers are typically supposed to be quiet unless they are actually
> probed, but for some reason, USB host controllers seem to be exempt from
> this rule, and happily broadcast their existence into the kernel log at
> boot even if the hardware in question is nowhere to be found.
> 
> Let's fix that, and remove these pr_info() calls.
> 
> Cc: Alan Stern <stern@...land.harvard.edu>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org> 
> Cc: Nicolas Ferre <nicolas.ferre@...rochip.com>
> Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>
> Cc: Claudiu Beznea <claudiu.beznea@...rochip.com>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Cc: Alim Akhtar <alim.akhtar@...sung.com>
> Cc: Avi Fishman <avifishman70@...il.com>
> Cc: Tomer Maimon <tmaimon77@...il.com>
> Cc: Tali Perry <tali.perry1@...il.com>
> Cc: Patrick Venture <venture@...gle.com>
> Cc: Nancy Yuen <yuenn@...gle.com>
> Cc: Benjamin Fair <benjaminfair@...gle.com>
> Cc: Patrice Chotard <patrice.chotard@...s.st.com>
> Cc: Vladimir Zapolskiy <vz@...ia.com>
> Cc: linux-usb@...r.kernel.org
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-kernel@...r.kernel.org
> Cc: linux-samsung-soc@...r.kernel.org
> Cc: linux-omap@...r.kernel.org
> Signed-off-by: Ard Biesheuvel <ardb@...nel.org>
> ---
>  drivers/usb/host/ehci-atmel.c    | 1 -
>  drivers/usb/host/ehci-exynos.c   | 1 -
>  drivers/usb/host/ehci-fsl.c      | 2 --
>  drivers/usb/host/ehci-hcd.c      | 1 -
>  drivers/usb/host/ehci-npcm7xx.c  | 2 --
>  drivers/usb/host/ehci-omap.c     | 2 --
>  drivers/usb/host/ehci-orion.c    | 2 --
>  drivers/usb/host/ehci-pci.c      | 2 --
>  drivers/usb/host/ehci-platform.c | 2 --
>  drivers/usb/host/ehci-spear.c    | 2 --
>  drivers/usb/host/ehci-st.c       | 2 --
>  drivers/usb/host/fotg210-hcd.c   | 1 -
>  drivers/usb/host/ohci-at91.c     | 1 -
>  drivers/usb/host/ohci-da8xx.c    | 1 -
>  drivers/usb/host/ohci-exynos.c   | 1 -
>  drivers/usb/host/ohci-hcd.c      | 1 -
>  drivers/usb/host/ohci-nxp.c      | 2 --
>  drivers/usb/host/ohci-omap.c     | 2 --
>  drivers/usb/host/ohci-pci.c      | 2 --
>  drivers/usb/host/ohci-platform.c | 2 --
>  drivers/usb/host/ohci-pxa27x.c   | 2 --
>  drivers/usb/host/ohci-s3c2410.c  | 1 -
>  drivers/usb/host/ohci-spear.c    | 2 --
>  drivers/usb/host/ohci-st.c       | 2 --


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>


Best regards,
Krzysztof