linux-kernel - Re: [PATCH v8 095/103] KVM: TDX: Handle TDX PV rdmsr/wrmsr hypercall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220826064629.GG2538772@ls.amr.corp.intel.com>
Date:   Thu, 25 Aug 2022 23:46:29 -0700
From:   Isaku Yamahata <isaku.yamahata@...il.com>
To:     Sagi Shahar <sagis@...gle.com>
Cc:     "Yamahata, Isaku" <isaku.yamahata@...el.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Isaku Yamahata <isaku.yamahata@...il.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Erdem Aktas <erdemaktas@...gle.com>,
        Sean Christopherson <seanjc@...gle.com>
Subject: Re: [PATCH v8 095/103] KVM: TDX: Handle TDX PV rdmsr/wrmsr hypercall

On Wed, Aug 17, 2022 at 03:40:24PM -0700,
Sagi Shahar <sagis@...gle.com> wrote:

> On Sun, Aug 7, 2022 at 3:03 PM <isaku.yamahata@...el.com> wrote:
> > +static int tdx_emulate_wrmsr(struct kvm_vcpu *vcpu)
> > +{
> > +       u32 index = tdvmcall_a0_read(vcpu);
> > +       u64 data = tdvmcall_a1_read(vcpu);
> > +
> > +       if (!kvm_msr_allowed(vcpu, index, KVM_MSR_FILTER_READ) ||
>                                                                    ^
> This should be KVM_MSR_FILTER_WRITE

Oops. Thanks. I'll fix it.
-- 
Isaku Yamahata <isaku.yamahata@...il.com>