linux-kernel - [PATCH linux-next] scsi: snic: Remove the unneeded result variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 26 Aug 2022 07:26:48 +0000
From:   cgel.zte@...il.com
To:     martin.petersen@...cle.com
Cc:     kartilak@...co.com, sebaddel@...co.com, jejb@...ux.ibm.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        ye xingchen <ye.xingchen@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: [PATCH linux-next] scsi: snic: Remove the unneeded result variable

From: ye xingchen <ye.xingchen@....com.cn>

Return the value 0 and -ENOMEM  directly instead of storing it in another
redundant variable.

Reported-by: Zeal Robot <zealci@....com.cn>
Signed-off-by: ye xingchen <ye.xingchen@....com.cn>
---
 drivers/scsi/snic/snic_trc.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/scsi/snic/snic_trc.c b/drivers/scsi/snic/snic_trc.c
index c2e5ab7e976c..9796bf280775 100644
--- a/drivers/scsi/snic/snic_trc.c
+++ b/drivers/scsi/snic/snic_trc.c
@@ -109,16 +109,15 @@ snic_trc_init(void)
 {
 	struct snic_trc *trc = &snic_glob->trc;
 	void *tbuf = NULL;
-	int tbuf_sz = 0, ret;
+	int tbuf_sz = 0;
 
 	tbuf_sz = (snic_trace_max_pages * PAGE_SIZE);
 	tbuf = vzalloc(tbuf_sz);
 	if (!tbuf) {
 		SNIC_ERR("Failed to Allocate Trace Buffer Size. %d\n", tbuf_sz);
 		SNIC_ERR("Trace Facility not enabled.\n");
-		ret = -ENOMEM;
 
-		return ret;
+		return -ENOMEM;
 	}
 
 	trc->buf = (struct snic_trc_data *) tbuf;
@@ -131,9 +130,8 @@ snic_trc_init(void)
 	trc->enable = true;
 	SNIC_INFO("Trace Facility Enabled.\n Trace Buffer SZ %lu Pages.\n",
 		  tbuf_sz / PAGE_SIZE);
-	ret = 0;
 
-	return ret;
+	return 0;
 } /* end of snic_trc_init */
 
 /*
-- 
2.25.1