linux-kernel - Re: linux-next: build failure after merge of the mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ywh3C4dKB9B93jIy@dhcp22.suse.cz>
Date:   Fri, 26 Aug 2022 09:32:27 +0200
From:   Michal Hocko <mhocko@...e.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the mm tree

On Fri 26-08-22 17:10:20, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the mm tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> arch/powerpc/xmon/xmon.c: In function 'cmds':
> arch/powerpc/xmon/xmon.c:1089:33: error: too few arguments to function 'show_mem'
>  1089 |                                 show_mem(0, NULL);
>       |                                 ^~~~~~~~
> In file included from arch/powerpc/xmon/xmon.c:14:
> include/linux/mm.h:2585:13: note: declared here
>  2585 | extern void show_mem(unsigned int flags, nodemask_t *nodemask, gfp_t gfp_mask);
>       |             ^~~~~~~~
> 
> Caused by commit
> 
>   9ea9abc5cd7e ("mm: reduce noise in show_mem for lowmem allocations")
> 
> I have reverted that commit for today (and the following fix).

This should fix it. Andrew, could you fold it into the patch please?
git grep doesn't suggest more instances AFAICS
--- 
diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
index 3d9782ea3fa7..19b1a94b0c00 100644
--- a/arch/powerpc/xmon/xmon.c
+++ b/arch/powerpc/xmon/xmon.c
@@ -1086,7 +1086,7 @@ cmds(struct pt_regs *excp)
 				memzcan();
 				break;
 			case 'i':
-				show_mem(0, NULL);
+				show_mem(0, NULL, GFP_HIGHUSER_MOVABLE);
 				break;
 			default:
 				termch = cmd;


-- 
Michal Hocko
SUSE Labs