linux-kernel - Re: [PATCH V4] mm: fix use-after free of page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 26 Aug 2022 13:22:29 +0530
From:   Charan Teja Kalla <quic_charante@...cinc.com>
To:     David Hildenbrand <david@...hat.com>, <akpm@...ux-foundation.org>,
        <mhocko@...e.com>, <vbabka@...e.cz>, <pasha.tatashin@...een.com>,
        <shakeelb@...gle.com>, <sieberf@...zon.com>, <sjpark@...zon.de>,
        <william.kucharski@...cle.com>, <willy@...radead.org>,
        <quic_pkondeti@...cinc.com>, <minchan@...gle.com>
CC:     <linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>
Subject: Re: [PATCH V4] mm: fix use-after free of page_ext after race with
 memory-offline

Hi David,

On 8/23/2022 10:35 PM, Charan Teja Kalla wrote:
>> I kind-of dislike the "loop" labels. Can we come up with a more
>> expressive name?
>>
>> "put_continue"
>>
>> or something?
>>
>>
>> One alternative would be to add to the beginning of the loop, and after
>> the loop sth like
>>
>> if (page_ext) {
>> 	page_ext_put(page_ext);
>> 	page_ext = NULL;
>> }
> I think, moving this to beginning of the loop looks cleaner than the
> goto statement.  Will spin V5.
> 
I have realized that goto looks simpler and cleaner... Raised V5 @
https://lore.kernel.org/all/1661496993-11473-1-git-send-email-quic_charante@quicinc.com/
>