lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 26 Aug 2022 10:20:44 +0200 From: Linus Walleij <linus.walleij@...aro.org> To: Andy Shevchenko <andy.shevchenko@...il.com> Cc: Bartosz Golaszewski <brgl@...ev.pl>, Robert Jarzmik <robert.jarzmik@...e.fr>, "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Hulk Robot <hulkci@...wei.com>, Yuan Can <yuancan@...wei.com> Subject: Re: [PATCH] gpio: pxa: use devres for the clock struct On Sat, Aug 20, 2022 at 12:15 AM Andy Shevchenko <andy.shevchenko@...il.com> wrote: > On Mon, Aug 15, 2022 at 12:26 PM Bartosz Golaszewski <brgl@...ev.pl> wrote: > > > > The clock is never released after probe(). Use devres to not leak > > resources. > > ... > > > - clk = clk_get(&pdev->dev, NULL); > > + clk = devm_clk_get_enabled(&pdev->dev, NULL); > > if (IS_ERR(clk)) { > > dev_err(&pdev->dev, "Error %ld to get gpio clock\n", > > PTR_ERR(clk)); > > return PTR_ERR(clk); > > Shouldn't we fix a potential log saturation issue first (by switching > to use dev_err_probe() helper)? Can be a separate patch, the clock mem leak is a bigger problem IMO so this should be applied first. Hm isn't it possible to toss the task of fixing a gazillion dev_err_probe() messages on Cocinelle scripts/coccinelle/? I bet it's something the kernel janitors could fix all over the place. Yours, Linus Walleij
Powered by blists - more mailing lists