linux-kernel - Re: [PATCH net-next] net: sched: tbf: don't call qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fdca3c8d-42f6-1f2a-5b03-eaf3c394297d@huawei.com>
Date:   Fri, 26 Aug 2022 09:25:45 +0800
From:   shaozhengchao <shaozhengchao@...wei.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
        <jhs@...atatu.com>, <xiyou.wangcong@...il.com>, <jiri@...nulli.us>,
        <vladbu@...lanox.com>, <weiyongjun1@...wei.com>,
        <yuehaibing@...wei.com>
Subject: Re: [PATCH net-next] net: sched: tbf: don't call qdisc_put() while
 holding tree lock



On 2022/8/26 9:13, Jakub Kicinski wrote:
> On Fri, 26 Aug 2022 09:12:48 +0800 Zhengchao Shao wrote:
>> The issue is the same to commit c2999f7fb05b ("net: sched: multiq: don't
>> call qdisc_put() while holding tree lock"). Qdiscs call qdisc_put() while
>> holding sch tree spinlock, which results sleeping-while-atomic BUG.
>>
>> Fixes: c266f64dbfa2 ("net: sched: protect block state with mutex")
>> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>
> 
> If it's a bug fix for a commit already in Linus's main tree it should
> come with [PATCH net] in the subject (i.e. without the -next).
> Please repost.

Hi Jakub:
	Thank you for your reply. I will repost this patch.

Zhangchao Shao