[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7927ac6e-7738-822a-59ce-09992947f3b4@redhat.com>
Date: Fri, 26 Aug 2022 10:57:24 +0200
From: Daniel Bristot de Oliveira <bristot@...hat.com>
To: shangxiaojing <shangxiaojing@...wei.com>
Cc: mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com,
vincent.guittot@...aro.org, dietmar.eggemann@....com,
rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
vschneid@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] sched/deadline: Add start_new_instance helper
On 8/26/22 09:40, shangxiaojing wrote:
>> again, this is not a good function name. Maybe, dl_replenish_new_period() ?
>
> right, i have thought like replenish_new_instance, but when i'm making
> patch, i was worried that "replenish" is only for ENQUEUE_REPLENISH.
I see, but that is a flag, not the action.
> what about dl_start_new_period? which means a new deadline will be set, rather than
The thing it is doing is replenishing...
> dl_se->deadline += pi_of(dl_se)->dl_period;
>
> in replenish_dl_entity.
that is why I added "new_period".... so replenish_dl_new_period() to keep the consistency.
>>> +static inline void start_new_instance(struct sched_dl_entity *dl_se, struct rq *rq)
>>>
>>> +{
>>> + /* for non-boosted task, pi_of(dl_se) == dl_se */
>>> + dl_se->deadline = rq_clock(rq) + pi_of(dl_se)->dl_deadline;
>>> + dl_se->runtime = pi_of(dl_se)->dl_runtime;
>>> +}
>>> +
>> -- Daniel
-- Daniel
Powered by blists - more mailing lists