linux-kernel - Re: [PATCH] USB DAC broken since commit bf6313a0ff766925462e97b4e733d5952de02367 (5.10.0-rc5)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Aug 2022 09:07:55 +0000
From:   Lennert Van Alboom <lennert@...alboom.org>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "ls.yoyo.m@...il.com" <ls.yoyo.m@...il.com>
Subject: Re: [PATCH] USB DAC broken since commit bf6313a0ff766925462e97b4e733d5952de02367 (5.10.0-rc5)

------- Original Message -------
On Friday, August 26th, 2022 at 08:05, Takashi Iwai <tiwai@...e.de> wrote:
> 

> This option is passed per card instance, as the driver may hold
> multiple cards. Check your /proc/asound/cards. The first argument of
> quirk_flags is applied to the first USB-audio card, the second to the
> second USB audio device, and so on.
> 

> At best, give alsa-info.sh output before and after applying the
> quirk. Run the script with --no-upload option and attach the
> outputs.
> 

> And, as a reference, you can see the existing quirk tables in
> sound/usb/quirks.c.
> 

> 

> Takashi


Not sure why it failed before (didn't look further then, so possibly PEBKAC) but as you suggested, this works now (tested on debian's 5.19 kernel):

# modprobe snd_usb_audio vid=0x2522 pid=0x0007 quirk_flags=0x10000


Confirmed that setting a quirk_alias also works: 


# grep -A 1 "0x054c, 0x0b8c" linux/sound/usb/quirks.c 

	DEVICE_FLG(0x054c, 0x0b8c, /* Sony WALKMAN NW-A45 DAC */
		   QUIRK_FLAG_SET_IFACE_FIRST),
# modprobe snd_usb_audio quirk_alias=25220007:054c0b8c


I've added a patch for quirks.c to make this default behaviour for this device. Looking at the Arch bug report at https://bugs.archlinux.org/task/70636, it's likely similar behaviour may be needed for pid=0009 (LH Labs Geek Pulse X 1V5) but I have no way of testing this. Added the reporter in CC.


Thanks,


Lennert


Download attachment "patch" of type "application/octet-stream" (504 bytes)

Download attachment "publickey - lennert@...alboom.org - 0x0320C886.asc" of type "application/pgp-keys" (596 bytes)

Download attachment "signature.asc" of type "application/pgp-signature" (250 bytes)