linux-kernel - Re: spi: stm32-qspi: Fix stm32_qspi_transfer_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5bd8dfad-de31-a5ac-2efc-a9a3d80650f0@foss.st.com>
Date:   Fri, 26 Aug 2022 11:21:39 +0200
From:   Patrice CHOTARD <patrice.chotard@...s.st.com>
To:     Mark Brown <broonie@...nel.org>
CC:     <linux-spi@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <christophe.kerello@...s.st.com>,
        Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: spi: stm32-qspi: Fix stm32_qspi_transfer_one_message() error path

Hi Mark

Patch sent with incorrect commit title, a new one is in the pipe.
Sorry for that

Patrice

On 8/26/22 11:18, patrice.chotard@...s.st.com wrote:
> From: Patrice Chotard <patrice.chotard@...s.st.com>
> 
> The patch a557fca630cc: "spi: stm32_qspi: Add transfer_one_message()
> spi callback" from Aug 23, 2022, leads to the following Smatch static
> checker warning:
> 
> drivers/spi/spi-stm32-qspi.c:627 stm32_qspi_transfer_one_message()
> error: uninitialized symbol 'ret'.Fix the following Smatch static checker warning:
> 
> Fixes: a557fca630cc ("spi: stm32_qspi: Add transfer_one_message() spi callback")
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Patrice Chotard <patrice.chotard@...s.st.com>
> ---
>  drivers/spi/spi-stm32-qspi.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c
> index 92459daca95f..679fd1c34f7e 100644
> --- a/drivers/spi/spi-stm32-qspi.c
> +++ b/drivers/spi/spi-stm32-qspi.c
> @@ -562,7 +562,7 @@ static int stm32_qspi_transfer_one_message(struct spi_controller *ctrl,
>  	struct spi_transfer *transfer;
>  	struct spi_device *spi = msg->spi;
>  	struct spi_mem_op op;
> -	int ret;
> +	int ret = 0;
>  
>  	if (!spi->cs_gpiod)
>  		return -EOPNOTSUPP;
> @@ -592,8 +592,10 @@ static int stm32_qspi_transfer_one_message(struct spi_controller *ctrl,
>  			dummy_bytes = transfer->len;
>  
>  			/* if happens, means that message is not correctly built */
> -			if (list_is_last(&transfer->transfer_list, &msg->transfers))
> +			if (list_is_last(&transfer->transfer_list, &msg->transfers)) {
> +				ret = -EINVAL;
>  				goto end_of_transfer;
> +			}
>  
>  			transfer = list_next_entry(transfer, transfer_list);
>  		}