linux-kernel - Re: [PATCH] msm/adreno: fix repeated words in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9396ac0b-e8a1-e82d-65db-8abc0ee75491@linaro.org>
Date:   Fri, 26 Aug 2022 12:45:30 +0300
From:   Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To:     Jilin Yuan <yuanjilin@...rlc.com>, robdclark@...il.com,
        quic_abhinavk@...cinc.com, airlied@...ux.ie, daniel@...ll.ch
Cc:     linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        freedreno@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] msm/adreno: fix repeated words in comments

On 23/08/2022 14:56, Jilin Yuan wrote:
>   Delete the redundant word 'power'.
>   Delete the redundant word 'in'.
>   Delete the redundant word 'for'.
> 
> Signed-off-by: Jilin Yuan <yuanjilin@...rlc.com>

Could you please:
- adjust the commit subject to follow the rest of commit messages,
- drop the extra whitespace at the beginning of the commit message,
- add a correct Fixes tag.

Thank you

> ---
>   drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> index 9f76f5b15759..32ecb783c3c1 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> @@ -352,7 +352,7 @@ void a6xx_gmu_clear_oob(struct a6xx_gmu *gmu, enum a6xx_gmu_oob_state state)
>   	gmu_write(gmu, REG_A6XX_GMU_HOST2GMU_INTR_SET, 1 << bit);
>   }
>   
> -/* Enable CPU control of SPTP power power collapse */
> +/* Enable CPU control of SPTP power collapse */
>   static int a6xx_sptprac_enable(struct a6xx_gmu *gmu)
>   {
>   	int ret;
> @@ -374,7 +374,7 @@ static int a6xx_sptprac_enable(struct a6xx_gmu *gmu)
>   	return 0;
>   }
>   
> -/* Disable CPU control of SPTP power power collapse */
> +/* Disable CPU control of SPTP power collapse */
>   static void a6xx_sptprac_disable(struct a6xx_gmu *gmu)
>   {
>   	u32 val;
> @@ -1277,7 +1277,7 @@ static int a6xx_gmu_rpmh_arc_votes_init(struct device *dev, u32 *votes,
>   		}
>   
>   		/*
> -		 * Look for a level in in the secondary list that matches. If
> +		 * Look for a level in the secondary list that matches. If
>   		 * nothing fits, use the maximum non zero vote
>   		 */
>   
> @@ -1559,7 +1559,7 @@ int a6xx_gmu_init(struct a6xx_gpu *a6xx_gpu, struct device_node *node)
>   			goto err_memory;
>   	}
>   
> -	/* Allocate memory for for the HFI queues */
> +	/* Allocate memory for the HFI queues */
>   	ret = a6xx_gmu_memory_alloc(gmu, &gmu->hfi, SZ_16K, 0, "hfi");
>   	if (ret)
>   		goto err_memory;

-- 
With best wishes
Dmitry