linux-kernel - Re: [PATCH] KVM: x86: use TPAUSE to replace PAUSE in halt polling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Aug 2022 12:14:29 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     "Mi, Dapeng1" <dapeng1.mi@...el.com>,
        "Christopherson,, Sean" <seanjc@...gle.com>
Cc:     "rafael@...nel.org" <rafael@...nel.org>,
        "daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "zhenyuw@...ux.intel.com" <zhenyuw@...ux.intel.com>
Subject: Re: [PATCH] KVM: x86: use TPAUSE to replace PAUSE in halt polling

On 8/25/22 13:31, Mi, Dapeng1 wrote:
>> I say "if", because I think this needs to come with performance numbers to show
>> the impact on guest latency so that KVM and its users can make an informed
>> decision.
>> And if it's unlikely that anyone will ever want to enable TPAUSE for halt polling,
>> then it's not worth the extra complexity in KVM.
> I ever run two scheduling related benchmarks, hackbench and schbench, I didn't see  there are obvious performance impact.
> 
> Here are the hackbench and schbench data on Intel ADL platform.

Can you confirm (using debugfs for example) that halt polling is used 
while hackbench is running, and not used while it is not running?

In particular, I think you need to run the server and client on 
different VMs, for example using netperf's UDP_RR test.  With hackbench 
the ping-pong is simply between two tasks on the same CPU, and the 
hypervisor is not exercised at all.

Paolo