linux-kernel - Re: [PATCH] intel_th: Fix dma_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 26 Aug 2022 12:39:24 +0200
From:   Jinpu Wang <jinpu.wang@...os.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     alexander.shishkin@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] intel_th: Fix dma_map_sg error check

On Fri, Aug 26, 2022 at 12:31 PM Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:
>
> Le 26/08/2022 à 12:15, Jack Wang a écrit :
> > dma_map_sg return 0 on error.
> >
> > Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
> > Cc: linux-kernel@...r.kernel.org
> > Fixes: 4e0eaf239fb3 ("intel_th: msu: Fix single mode with IOMMU")
> > Signed-off-by: Jack Wang <jinpu.wang@...os.com>
> > ---
> >   drivers/hwtracing/intel_th/msu.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hwtracing/intel_th/msu.c b/drivers/hwtracing/intel_th/msu.c
> > index 6c8215a47a60..b49237d56a60 100644
> > --- a/drivers/hwtracing/intel_th/msu.c
> > +++ b/drivers/hwtracing/intel_th/msu.c
> > @@ -931,7 +931,7 @@ static int msc_buffer_contig_alloc(struct msc *msc, unsigned long size)
> >
> >       ret = dma_map_sg(msc_dev(msc)->parent->parent, msc->single_sgt.sgl, 1,
> >                        DMA_FROM_DEVICE);
> > -     if (ret < 0)
> > +     if (!ret)
>
> Missing ret = -EIO?
> like in other patches?
oh, right, thx for catching it.
sent v2 patch.
>
> CJ
>
> >               goto err_free_pages;
> >
> >       msc->nr_pages = nr_pages;
>