linux-kernel - Re: [PATCH] crypto: lib - remove unneeded selection of XOR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ywip6/79IEQFXt3g@gondor.apana.org.au>
Date:   Fri, 26 Aug 2022 19:09:31 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     linux-crypto@...r.kernel.org,
        "Jason A . Donenfeld " <Jason@...c4.com>,
        "Justin M . Forbes" <jforbes@...oraproject.org>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] crypto: lib - remove unneeded selection of XOR_BLOCKS

On Thu, Aug 25, 2022 at 10:04:56PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> CRYPTO_LIB_CHACHA_GENERIC doesn't need to select XOR_BLOCKS.  It perhaps
> was thought that it's needed for __crypto_xor, but that's not the case.
> 
> Enabling XOR_BLOCKS is problematic because the XOR_BLOCKS code runs a
> benchmark when it is initialized.  That causes a boot time regression on
> systems that didn't have it enabled before.
> 
> Therefore, remove this unnecessary and problematic selection.
> 
> Fixes: e56e18985596 ("lib/crypto: add prompts back to crypto libraries")
> Cc: stable@...r.kernel.org
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> ---
> 
> I've separated this fix out from the larger patch
> https://lore.kernel.org/r/20220725183636.97326-3-ebiggers@kernel.org
> that is currently queued in cryptodev.
> 
>  lib/crypto/Kconfig | 1 -
>  1 file changed, 1 deletion(-)

Patch applied.  Thanks. 
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt