[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20220826122352.288438-1-shreeya.patel@collabora.com>
Date: Fri, 26 Aug 2022 17:53:52 +0530
From: Shreeya Patel <shreeya.patel@...labora.com>
To: jic23@...nel.org, lars@...afoo.de
Cc: krisman@...labora.com, dmitry.osipenko@...labora.com,
kernel@...labora.com, linux-iio@...r.kernel.org,
linux-kernel@...r.kernel.org,
Shreeya Patel <shreeya.patel@...labora.com>,
stable@...r.kernel.org
Subject: [PATCH v2] iio: light: tsl2583: Fix module unloading
tsl2583 uses devm_iio_device_register() function and
calling iio_device_unregister() in remove breaks the
module unloading.
Fix this by using iio_device_register() instead of
devm_iio_device_register() function in probe.
Cc: stable@...r.kernel.org
Fixes: 371894f5d1a0 ("iio: tsl2583: add runtime power management support")
Signed-off-by: Shreeya Patel <shreeya.patel@...labora.com>
---
Changes in v2
- Use iio_device_register() instead of devm_iio_device_register()
- Add fixes and stable tags
drivers/iio/light/tsl2583.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/light/tsl2583.c b/drivers/iio/light/tsl2583.c
index 82662dab87c0..94d75ec687c3 100644
--- a/drivers/iio/light/tsl2583.c
+++ b/drivers/iio/light/tsl2583.c
@@ -858,7 +858,7 @@ static int tsl2583_probe(struct i2c_client *clientp,
TSL2583_POWER_OFF_DELAY_MS);
pm_runtime_use_autosuspend(&clientp->dev);
- ret = devm_iio_device_register(indio_dev->dev.parent, indio_dev);
+ ret = iio_device_register(indio_dev);
if (ret) {
dev_err(&clientp->dev, "%s: iio registration failed\n",
__func__);
--
2.30.2
Powered by blists - more mailing lists