| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <fd249ce0-f065-e522-d6c7-72985367cc53@intel.com>
Date: Fri, 26 Aug 2022 15:36:46 +0300
From: Adrian Hunter <adrian.hunter@...el.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>,
Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Jiri Olsa <jolsa@...nel.org>,
Namhyung Kim <namhyung@...nel.org>,
Thomas Gleixner <tglx@...utronix.de>,
Darren Hart <dvhart@...radead.org>,
Davidlohr Bueso <dave@...olabs.net>,
André Almeida <andrealmeid@...lia.com>,
Nathan Chancellor <nathan@...nel.org>,
Nick Desaulniers <ndesaulniers@...gle.com>,
Tom Rix <trix@...hat.com>, Weiguo Li <liwg06@...mail.com>,
Athira Rajeev <atrajeev@...ux.vnet.ibm.com>,
Thomas Richter <tmricht@...ux.ibm.com>,
Ravi Bangoria <ravi.bangoria@....com>,
Dario Petrillo <dario.pk1@...il.com>,
Hewenliang <hewenliang4@...wei.com>,
yaowenbin <yaowenbin1@...wei.com>,
Wenyu Liu <liuwenyu7@...wei.com>,
Song Liu <songliubraving@...com>,
Andrii Nakryiko <andrii@...nel.org>,
Dave Marchevsky <davemarchevsky@...com>,
Leo Yan <leo.yan@...aro.org>,
Kim Phillips <kim.phillips@....com>,
Pavithra Gurushankar <gpavithrasha@...il.com>,
Alexandre Truong <alexandre.truong@....com>,
Quentin Monnet <quentin@...valent.com>,
William Cohen <wcohen@...hat.com>,
Andres Freund <andres@...razel.de>,
Martin Liška <mliska@...e.cz>,
Colin Ian King <colin.king@...el.com>,
James Clark <james.clark@....com>,
Fangrui Song <maskray@...gle.com>,
Stephane Eranian <eranian@...gle.com>,
Kajol Jain <kjain@...ux.ibm.com>,
Alexey Bayduraev <alexey.v.bayduraev@...ux.intel.com>,
Riccardo Mancini <rickyman7@...il.com>,
Andi Kleen <ak@...ux.intel.com>,
Masami Hiramatsu <mhiramat@...nel.org>,
Zechuan Chen <chenzechuan1@...wei.com>,
Jason Wang <wangborong@...rlc.com>,
Christophe JAILLET <christophe.jaillet@...adoo.fr>,
Remi Bernon <rbernon@...eweavers.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
linux-perf-users <linux-perf-users@...r.kernel.org>,
bpf <bpf@...r.kernel.org>, llvm@...ts.linux.dev
Subject: Re: [PATCH v3 00/18] Mutex wrapper, locking and memory leak fixes
On 25/08/22 19:14, Adrian Hunter wrote:
> On 25/08/22 15:30, Arnaldo Carvalho de Melo wrote:
>> On Wed, Aug 24, 2022, 12:39 PM Ian Rogers <irogers@...gle.com <mailto:irogers@...gle.com>> wrote:
>>
>> When fixing a locking race and memory leak in:
>> https://lore.kernel.org/linux-perf-users/20211118193714.2293728-1-irogers@google.com/ <https://lore.kernel.org/linux-perf-users/20211118193714.2293728-1-irogers@google.com/>
>>
>> It was requested that debug mutex code be separated out into its own
>> files. This was, in part, done by Pavithra Gurushankar in:
>> https://lore.kernel.org/lkml/20220727111954.105118-1-gpavithrasha@gmail.com/ <https://lore.kernel.org/lkml/20220727111954.105118-1-gpavithrasha@gmail.com/>
>>
>> These patches fix issues with the previous patches, add in the
>> original dso->nsinfo fix and then build on our mutex wrapper with
>> clang's -Wthread-safety analysis. The analysis found missing unlocks
>> in builtin-sched.c which are fixed and -Wthread-safety is enabled by
>> default when building with clang.
>>
>> v3. Adds a missing new line to the error messages and removes the
>> pshared argument to mutex_init by having two functions, mutex_init
>> and mutex_init_pshared. These changes were suggested by Adrian Hunter.
>>
>>
>> Adrian, can I have your Acked-by or, better, Reviewed-by?
>
> Sure, just let me have another look. Should get to it
> tomorrow.
Looks good but a couple of things that need to be fixed up.
>
>>
>> Thanks,
>>
>> - Arnaldo
>>
>> v2. Breaks apart changes that s/pthread_mutex/mutex/g and the lock
>> annotations as requested by Arnaldo and Namhyung. A boolean is
>> added to builtin-sched.c to terminate thread funcs rather than
>> leaving them blocked on delted mutexes.
>>
>> Ian Rogers (17):
>> perf bench: Update use of pthread mutex/cond
>> perf tests: Avoid pthread.h inclusion
>> perf hist: Update use of pthread mutex
>> perf bpf: Remove unused pthread.h include
>> perf lock: Remove unused pthread.h include
>> perf record: Update use of pthread mutex
>> perf sched: Update use of pthread mutex
>> perf ui: Update use of pthread mutex
>> perf mmap: Remove unnecessary pthread.h include
>> perf dso: Update use of pthread mutex
>> perf annotate: Update use of pthread mutex
>> perf top: Update use of pthread mutex
>> perf dso: Hold lock when accessing nsinfo
>> perf mutex: Add thread safety annotations
>> perf sched: Fixes for thread safety analysis
>> perf top: Fixes for thread safety analysis
>> perf build: Enable -Wthread-safety with clang
>>
>> Pavithra Gurushankar (1):
>> perf mutex: Wrapped usage of mutex and cond
>>
>> tools/perf/Makefile.config | 5 +
>> tools/perf/bench/epoll-ctl.c | 33 +++---
>> tools/perf/bench/epoll-wait.c | 33 +++---
>> tools/perf/bench/futex-hash.c | 33 +++---
>> tools/perf/bench/futex-lock-pi.c | 33 +++---
>> tools/perf/bench/futex-requeue.c | 33 +++---
>> tools/perf/bench/futex-wake-parallel.c | 33 +++---
>> tools/perf/bench/futex-wake.c | 33 +++---
>> tools/perf/bench/numa.c | 93 ++++++----------
>> tools/perf/builtin-inject.c | 4 +
>> tools/perf/builtin-lock.c | 1 -
>> tools/perf/builtin-record.c | 13 ++-
>> tools/perf/builtin-sched.c | 105 +++++++++---------
>> tools/perf/builtin-top.c | 45 ++++----
>> tools/perf/tests/mmap-basic.c | 2 -
>> tools/perf/tests/openat-syscall-all-cpus.c | 2 +-
>> tools/perf/tests/perf-record.c | 2 -
>> tools/perf/ui/browser.c | 20 ++--
>> tools/perf/ui/browsers/annotate.c | 12 +--
>> tools/perf/ui/setup.c | 5 +-
>> tools/perf/ui/tui/helpline.c | 5 +-
>> tools/perf/ui/tui/progress.c | 8 +-
>> tools/perf/ui/tui/setup.c | 8 +-
>> tools/perf/ui/tui/util.c | 18 ++--
>> tools/perf/ui/ui.h | 4 +-
>> tools/perf/util/Build | 1 +
>> tools/perf/util/annotate.c | 15 +--
>> tools/perf/util/annotate.h | 4 +-
>> tools/perf/util/bpf-event.h | 1 -
>> tools/perf/util/build-id.c | 12 ++-
>> tools/perf/util/dso.c | 19 ++--
>> tools/perf/util/dso.h | 4 +-
>> tools/perf/util/hist.c | 6 +-
>> tools/perf/util/hist.h | 4 +-
>> tools/perf/util/map.c | 3 +
>> tools/perf/util/mmap.h | 1 -
>> tools/perf/util/mutex.c | 119 +++++++++++++++++++++
>> tools/perf/util/mutex.h | 109 +++++++++++++++++++
>> tools/perf/util/probe-event.c | 3 +
>> tools/perf/util/symbol.c | 4 +-
>> tools/perf/util/top.h | 5 +-
>> 41 files changed, 570 insertions(+), 323 deletions(-)
>> create mode 100644 tools/perf/util/mutex.c
>> create mode 100644 tools/perf/util/mutex.h
>>
>> --
>> 2.37.2.609.g9ff673ca1a-goog
>>
>
Powered by blists - more mailing lists