linux-kernel - Re: [PATCH 1/3] serial: Rename vars in uart_get_rs485

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vc8jNDUnEMBcQqe0mvM_o-16TM+f3xjn1NMuedNd6wJZA@mail.gmail.com>
Date:   Fri, 26 Aug 2022 18:39:57 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Lino Sanfilippo <LinoSanfilippo@....de>
Subject: Re: [PATCH 1/3] serial: Rename vars in uart_get_rs485_config()

On Fri, Aug 26, 2022 at 5:50 PM Ilpo Järvinen
<ilpo.jarvinen@...ux.intel.com> wrote:
>
> Make variable names to match uart_set_rs485_config() ones:
>         - rs485 -> rs485_user
>         - aux -> rs485

Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
(see below)

> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> ---
>  drivers/tty/serial/serial_core.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index 12c87cd201a7..9c1bf36b7a93 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -1408,16 +1408,16 @@ int uart_rs485_config(struct uart_port *port)
>  EXPORT_SYMBOL_GPL(uart_rs485_config);
>
>  static int uart_get_rs485_config(struct uart_port *port,
> -                        struct serial_rs485 __user *rs485)
> +                        struct serial_rs485 __user *rs485_user)
>  {
>         unsigned long flags;
> -       struct serial_rs485 aux;
> +       struct serial_rs485 rs485;

At the same time you may order it by "the longest line first".

>         spin_lock_irqsave(&port->lock, flags);
> -       aux = port->rs485;
> +       rs485 = port->rs485;
>         spin_unlock_irqrestore(&port->lock, flags);
>
> -       if (copy_to_user(rs485, &aux, sizeof(aux)))
> +       if (copy_to_user(rs485_user, &rs485, sizeof(rs485)))
>                 return -EFAULT;
>
>         return 0;

-- 
With Best Regards,
Andy Shevchenko