linux-kernel - Re: [PATCH] iio:accel:dmard06: Optimize when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Aug 2022 19:10:33 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Jean Delvare <jdelvare@...e.de>
Cc:     linux-iio <linux-iio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH] iio:accel:dmard06: Optimize when CONFIG_OF isn't set

On Fri, Aug 26, 2022 at 7:06 PM Jean Delvare <jdelvare@...e.de> wrote:
> On Fri, 26 Aug 2022 18:18:20 +0300, Andy Shevchenko wrote:
> > On Fri, Aug 26, 2022 at 1:46 PM Jean Delvare <jdelvare@...e.de> wrote:
> > > therefore of_match_ptr() should be
> > > removed from the kernel entirely?
> >
> > (...) But for some cases it still
> > makes sense: platform is known to never be non-OF, component is known
> > to be used only on such platforms, etc.
>
> Well, I can't see the value of of_match_ptr() in such case either. In
> fact I've submitted a couple patches to remove such occurrences lately:
>
> https://patchwork.kernel.org/project/linux-mediatek/patch/20220730144833.0a0d9825@endymion.delvare/
> https://patchwork.kernel.org/project/linux-pm/patch/20220804135938.7f69f5d9@endymion.delvare/

They are different to what we are discussing here, but yes, in common
denominator the of_match_ptr() is useless in almost 100% cases.

-- 
With Best Regards,
Andy Shevchenko