linux-kernel - Re: [PATCH] gpio: pxa: use devres for the clock struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <06339802-8c3e-2a40-e4fd-6a8a774676fe@wanadoo.fr>
Date:   Sat, 27 Aug 2022 14:35:39 +0200
From:   Marion & Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Bartosz Golaszewski <brgl@...ev.pl>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Hulk Robot <hulkci@...wei.com>, Yuan Can <yuancan@...wei.com>,
        Kernel Janitors <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] gpio: pxa: use devres for the clock struct



Le 26/08/2022 à 14:18, Christophe JAILLET a écrit :
> Le 26/08/2022 à 10:20, Linus Walleij a écrit :
>> On Sat, Aug 20, 2022 at 12:15 AM Andy Shevchenko
>> <andy.shevchenko@...il.com> wrote:
>>> On Mon, Aug 15, 2022 at 12:26 PM Bartosz Golaszewski <brgl@...ev.pl> 
>>> wrote:
>>>>
>>>> The clock is never released after probe(). Use devres to not leak
>>>> resources.
>>>
>>> ...
>>>
>>>> -       clk = clk_get(&pdev->dev, NULL);
>>>> +       clk = devm_clk_get_enabled(&pdev->dev, NULL);
>>>>          if (IS_ERR(clk)) {
>>>>                  dev_err(&pdev->dev, "Error %ld to get gpio clock\n",
>>>>                          PTR_ERR(clk));
>>>>                  return PTR_ERR(clk);
>>>
>>> Shouldn't we fix a potential log saturation issue first (by switching
>>> to use dev_err_probe() helper)?
>>
>> Can be a separate patch, the clock mem leak is a bigger problem
>> IMO so this should be applied first.
>>
>> Hm isn't it possible to toss the task of fixing a gazillion
>> dev_err_probe() messages on Cocinelle scripts/coccinelle/? I bet it's 
>> something
>> the kernel janitors could fix all over the place.
>>
>> Yours,
>> Linus Walleij
>>
>
> // Both rules: 316 files changed, 1321 insertions(+), 1774 deletions(-)
> 


With an updated script, I spot:
    503 files changed, 1962 insertions(+), 2622 deletions(-)

(and 150-200 still needs some manual check or script adjustment)


Does this really make sense to send SO many patches for it?

If yes, should it be done on a per-system basis, or by driver basis?

CJ