lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 27 Aug 2022 18:46:29 +0200 From: Andrew Lunn <andrew@...n.ch> To: Oleksij Rempel <o.rempel@...gutronix.de> Cc: Heiner Kallweit <hkallweit1@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Russell King <linux@...linux.org.uk>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Jonathan Corbet <corbet@....net>, kernel@...gutronix.de, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-doc@...r.kernel.org, David Jander <david@...tonic.nl>, Luka Perkov <luka.perkov@...tura.hr>, Robert Marko <robert.marko@...tura.hr> Subject: Re: [PATCH net-next v3 5/7] net: mdiobus: search for PSE nodes by parsing PHY nodes. > @@ -26,6 +26,7 @@ > #include <linux/netdevice.h> > #include <linux/phy.h> > #include <linux/phy_led_triggers.h> > +#include <linux/pse-pd/pse.h> > #include <linux/property.h> > #include <linux/sfp.h> > #include <linux/skbuff.h> > @@ -988,6 +989,7 @@ EXPORT_SYMBOL(phy_device_register); > */ > void phy_device_remove(struct phy_device *phydev) > { > + pse_control_put(phydev->psec); > unregister_mii_timestamper(phydev->mii_ts); Just a nit-pick: I try to do remove in the opposite order to register, just in case there are any inter-dependencies. It seems very unlikely that the time stamper would depend on the psa, but the order performed in register would allow it. Reviewed-by: Andrew Lunn <andrew@...n.ch> Andrew
Powered by blists - more mailing lists