linux-kernel - Re: [PATCH v4 2/5] x86: Add resolve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0cb45c3090293039fb32e47b4fa181dc@ispras.ru>
Date:   Sat, 27 Aug 2022 04:51:08 +0300
From:   Evgeniy Baskov <baskov@...ras.ru>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/5] x86: Add resolve_cmdline() helper

On 2022-08-26 14:35, Borislav Petkov wrote:
> On Wed, May 25, 2022 at 01:10:10PM +0300, Evgeniy Baskov wrote:
>> Command line needs to be combined in both compressed and uncompressed
>> kernel from built-in and boot command line strings, which requires
>> non-trivial logic depending on CONFIG_CMDLINE_BOOL and
>> CONFIG_CMDLINE_OVERRIDE.
>> 
>> Add a helper function to avoid code duplication.
>> 
>> Signed-off-by: Evgeniy Baskov <baskov@...ras.ru>
>> 
> 
> You have some weird configuration to your git send-email which doesn't
> add the "---" to split the patch commit message from the diffstat.

Thanks, apparently "--summary" removes that.

...
> 
> So that has been switched to strscpy() in the meantime:
> 
> 8a33d96bd178 ("x86/setup: Use strscpy() to replace deprecated 
> strlcpy()")

I did already replace strlcpy() in v5, but since there are new changes
needed, I will send v6 with those changes applied soon.
So, please, ignore v5 then.

> 
> Please redo your set ontop of latest tip/master.

Will do.

Thanks,
Evgeniy Baskov