linux-kernel - Re: [PATCH 09/10] hugetlb: remove meaningless BUG_ON(huge_pte

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <399D37BF-B33B-476F-97D4-AEB812316617@linux.dev>
Date:   Sat, 27 Aug 2022 10:03:19 +0800
From:   Muchun Song <muchun.song@...ux.dev>
To:     Miaohe Lin <linmiaohe@...wei.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Muchun Song <songmuchun@...edance.com>,
        Linux MM <linux-mm@...ck.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 09/10] hugetlb: remove meaningless BUG_ON(huge_pte_none())



> On Aug 26, 2022, at 17:24, Miaohe Lin <linmiaohe@...wei.com> wrote:
> 
> When code reaches here, invalid page would have been accessed if huge pte
> is none. So this BUG_ON(huge_pte_none()) is meaningless. Remove it.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>

Reviewed-by: Muchun Song <songmuchun@...edance.com>

Thanks.