[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c90c6f86-dc0f-07bd-2abe-77d31716ee91@huawei.com>
Date: Sat, 27 Aug 2022 11:11:44 +0800
From: Zhiqiang Liu <liuzhiqiang26@...wei.com>
To: "Darrick J. Wong" <djwong@...nel.org>, <linux-xfs@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC: linfeilong <linfeilong@...wei.com>,
wuguanghao <wuguanghao3@...wei.com>
Subject: Re: [PATCH] xfs: donot need to check return value of xlog_kvmalloc()
friendly ping..
On 2022/8/22 19:46, Zhiqiang Liu wrote:
> In xfs_attri_log_nameval_alloc(), xlog_kvmalloc() is called
> to alloc memory, which will always return
> successfully, so we donot need to check return value.
>
> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@...wei.com>
> ---
> fs/xfs/xfs_attr_item.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_attr_item.c b/fs/xfs/xfs_attr_item.c
> index 5077a7ad5646..667e151a2bca 100644
> --- a/fs/xfs/xfs_attr_item.c
> +++ b/fs/xfs/xfs_attr_item.c
> @@ -86,8 +86,6 @@ xfs_attri_log_nameval_alloc(
> */
> nv = xlog_kvmalloc(sizeof(struct xfs_attri_log_nameval) +
> name_len + value_len);
> - if (!nv)
> - return nv;
>
> nv->name.i_addr = nv + 1;
> nv->name.i_len = name_len;
Powered by blists - more mailing lists