linux-kernel - Re: [PATCH -next] net: sched: sch_skbprio: add support for qlen statistics of each priority in sch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <865db8c4-63c1-d2f4-585f-26c3be713948@huawei.com>
Date:   Sat, 27 Aug 2022 12:20:30 +0800
From:   shaozhengchao <shaozhengchao@...wei.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
        <jhs@...atatu.com>, <xiyou.wangcong@...il.com>, <jiri@...nulli.us>,
        <weiyongjun1@...wei.com>, <yuehaibing@...wei.com>
Subject: Re: [PATCH -next] net: sched: sch_skbprio: add support for qlen
 statistics of each priority in sch_skbprio



On 2022/8/27 10:46, Jakub Kicinski wrote:
> On Thu, 25 Aug 2022 18:27:45 +0800 Zhengchao Shao wrote:
>> diff --git a/net/sched/sch_skbprio.c b/net/sched/sch_skbprio.c
>> index 7a5e4c454715..fe2bb7bf9d2a 100644
>> --- a/net/sched/sch_skbprio.c
>> +++ b/net/sched/sch_skbprio.c
>> @@ -83,6 +83,7 @@ static int skbprio_enqueue(struct sk_buff *skb, struct Qdisc *sch,
>>   		__skb_queue_tail(qdisc, skb);
> 
> The skb queue called "qdisc" here (confusingly) already maintains
> a length (also called qlen). Can we just access that variable instead
> of maintaining the same value manually?
> 
>>   		qdisc_qstats_backlog_inc(sch, skb);
>>   		q->qstats[prio].backlog += qdisc_pkt_len(skb);
>> +		q->qstats[prio].qlen++;
> 

Hi Jakub:
	Thank you for your reply. You are right, I have missed something. This 
patch seems to be unnecessary.

Zhengchao Shao