| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202208281813.FLX7bLix-lkp@intel.com>
Date: Sun, 28 Aug 2022 18:19:37 +0800
From: kernel test robot <lkp@...el.com>
To: Ard Biesheuvel <ardb@...nel.org>
Cc: llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
linux-kernel@...r.kernel.org
Subject: [ardb:for-kernelci 9/26]
drivers/firmware/efi/libstub/zboot.c:160:23: warning: no previous prototype
for function 'efi_zboot_entry'
tree: git://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git for-kernelci
head: f73ff3c33fc5ad785682e0892d9fb664616cd9c0
commit: 3d0326fd09d1289fb3b1504e65381cae574ea9dc [9/26] efi/libstub: implement generic EFI zboot
config: riscv-randconfig-c006-20220828 (https://download.01.org/0day-ci/archive/20220828/202208281813.FLX7bLix-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project a2100daf12fb980a29fd1a9c85ccf8eaaaf79730)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git/commit/?id=3d0326fd09d1289fb3b1504e65381cae574ea9dc
git remote add ardb git://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git
git fetch --no-tags ardb for-kernelci
git checkout 3d0326fd09d1289fb3b1504e65381cae574ea9dc
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/firmware/efi/libstub/ drivers/gpu/drm/bridge/imx/ drivers/gpu/drm/rcar-du/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
drivers/firmware/efi/libstub/zboot.c:90:22: error: call to undeclared function 'get_unaligned_le32'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
size = decompress ? get_unaligned_le32(_gzdata_end - 4)
^
drivers/firmware/efi/libstub/zboot.c:90:22: note: did you mean 'get_unaligned16'?
drivers/firmware/efi/libstub/../../../../lib/zlib_inflate/inffast.c:20:1: note: 'get_unaligned16' declared here
get_unaligned16(const unsigned short *p)
^
>> drivers/firmware/efi/libstub/zboot.c:160:23: warning: no previous prototype for function 'efi_zboot_entry' [-Wmissing-prototypes]
efi_status_t __efiapi efi_zboot_entry(efi_handle_t handle,
^
drivers/firmware/efi/libstub/zboot.c:160:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
efi_status_t __efiapi efi_zboot_entry(efi_handle_t handle,
^
static
1 warning and 1 error generated.
vim +/efi_zboot_entry +160 drivers/firmware/efi/libstub/zboot.c
57
58 static efi_status_t __efiapi
59 load_file(efi_load_file_protocol_t *this, efi_device_path_protocol_t *rem,
60 bool boot_policy, unsigned long *bufsize, void *buffer)
61 {
62 struct efi_vendor_dev_path *vendor_dp;
63 bool decompress = false;
64 unsigned long size;
65 int ret;
66
67 if (rem == NULL || bufsize == NULL)
68 return EFI_INVALID_PARAMETER;
69
70 if (boot_policy)
71 return EFI_UNSUPPORTED;
72
73 // Look for our vendor media device node in the remaining file path
74 if (rem->type == EFI_DEV_MEDIA &&
75 rem->sub_type == EFI_DEV_MEDIA_VENDOR) {
76 vendor_dp = container_of(rem, struct efi_vendor_dev_path, header);
77 if (!guids_eq(&vendor_dp->vendorguid, &LINUX_EFI_ZBOOT_MEDIA_GUID))
78 return EFI_NOT_FOUND;
79
80 decompress = true;
81 rem = (void *)(vendor_dp + 1);
82 }
83
84 if (rem->type != EFI_DEV_END_PATH ||
85 rem->sub_type != EFI_DEV_END_ENTIRE)
86 return EFI_NOT_FOUND;
87
88 // The uncompressed size of the payload is appended to the raw bit
89 // stream, and may therefore appear misaligned in memory
> 90 size = decompress ? get_unaligned_le32(_gzdata_end - 4)
91 : (_gzdata_end - _gzdata_start);
92 if (buffer == NULL || *bufsize < size) {
93 *bufsize = size;
94 return EFI_BUFFER_TOO_SMALL;
95 }
96
97 if (decompress) {
98 ret = __decompress(_gzdata_start, _gzdata_end - _gzdata_start,
99 NULL, NULL, buffer, 0, NULL, error);
100 if (ret < 0) {
101 log(L"Decompression failed");
102 return EFI_DEVICE_ERROR;
103 }
104 } else {
105 memcpy(buffer, _gzdata_start, size);
106 }
107
108 return EFI_SUCCESS;
109 }
110
111 // Return the length in bytes of the device path up to the first end node.
112 static int device_path_length(const efi_device_path_protocol_t *dp)
113 {
114 int len = 0;
115
116 while (dp->type != EFI_DEV_END_PATH) {
117 len += dp->length;
118 dp = (void *)((u8 *)dp + dp->length);
119 }
120 return len;
121 }
122
123 static void append_rel_offset_node(efi_device_path_protocol_t **dp,
124 unsigned long start, unsigned long end)
125 {
126 struct efi_rel_offset_dev_path *rodp = (void *)*dp;
127
128 rodp->header.type = EFI_DEV_MEDIA;
129 rodp->header.sub_type = EFI_DEV_MEDIA_REL_OFFSET;
130 rodp->header.length = sizeof(struct efi_rel_offset_dev_path);
131 rodp->reserved = 0;
132 rodp->starting_offset = start;
133 rodp->ending_offset = end;
134
135 *dp = (void *)(rodp + 1);
136 }
137
138 static void append_ven_media_node(efi_device_path_protocol_t **dp,
139 efi_guid_t *guid)
140 {
141 struct efi_vendor_dev_path *vmdp = (void *)*dp;
142
143 vmdp->header.type = EFI_DEV_MEDIA;
144 vmdp->header.sub_type = EFI_DEV_MEDIA_VENDOR;
145 vmdp->header.length = sizeof(struct efi_vendor_dev_path);
146 vmdp->vendorguid = *guid;
147
148 *dp = (void *)(vmdp + 1);
149 }
150
151 static void append_end_node(efi_device_path_protocol_t **dp)
152 {
153 (*dp)->type = EFI_DEV_END_PATH;
154 (*dp)->sub_type = EFI_DEV_END_ENTIRE;
155 (*dp)->length = sizeof(struct efi_generic_dev_path);
156
157 ++*dp;
158 }
159
> 160 efi_status_t __efiapi efi_zboot_entry(efi_handle_t handle,
--
0-DAY CI Kernel Test Service
https://01.org/lkp
Powered by blists - more mailing lists