linux-kernel - Re: [PATCH v12 09/17] iommu/vt-d: Add blocking domain support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18e43d40-577d-2878-5673-706defd699d5@linux.intel.com>
Date:   Sun, 28 Aug 2022 20:55:55 +0800
From:   Baolu Lu <baolu.lu@...ux.intel.com>
To:     Jason Gunthorpe <jgg@...dia.com>
Cc:     baolu.lu@...ux.intel.com, Joerg Roedel <joro@...tes.org>,
        Christoph Hellwig <hch@...radead.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Kevin Tian <kevin.tian@...el.com>,
        Ashok Raj <ashok.raj@...el.com>, Will Deacon <will@...nel.org>,
        Robin Murphy <robin.murphy@....com>,
        Jean-Philippe Brucker <jean-philippe@...aro.com>,
        Dave Jiang <dave.jiang@...el.com>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Vinod Koul <vkoul@...nel.org>,
        Eric Auger <eric.auger@...hat.com>,
        Liu Yi L <yi.l.liu@...el.com>,
        Jacob jun Pan <jacob.jun.pan@...el.com>,
        Zhangfei Gao <zhangfei.gao@...aro.org>,
        Zhu Tony <tony.zhu@...el.com>, iommu@...ts.linux.dev,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v12 09/17] iommu/vt-d: Add blocking domain support

On 2022/8/26 22:54, Jason Gunthorpe wrote:
> On Fri, Aug 26, 2022 at 08:11:33PM +0800, Lu Baolu wrote:
>> The Intel IOMMU hardwares support blocking DMA transactions by clearing
>> the translation table entries. This implements a real blocking domain to
>> avoid using an empty UNMANAGED domain. The detach_dev callback of the
>> domain ops is not used in any path. Remove it to avoid dead code as well.
>>
>> Signed-off-by: Lu Baolu <baolu.lu@...ux.intel.com>
>> Tested-by: Tony Zhu <tony.zhu@...el.com>
>> ---
>>   drivers/iommu/intel/iommu.c | 25 ++++++++++++++++++-------
>>   1 file changed, 18 insertions(+), 7 deletions(-)
> 
> At this point I'd suggest to make a little series that does all the
> blocking domain stuff in one shot
> 
> The removal of detach_dev callbacks is pretty nice for clarity.

Yes. As you saw, I have a separated series for above purpose.

Best regards,
baolu