lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 28 Aug 2022 19:12:12 +0200 From: Noralf Trønnes <noralf@...nnes.org> To: Maxime Ripard <maxime@...no.tech>, Jernej Skrabec <jernej.skrabec@...il.com>, Martin Blumenstingl <martin.blumenstingl@...glemail.com>, Chen-Yu Tsai <wens@...e.org>, Philipp Zabel <p.zabel@...gutronix.de>, Jerome Brunet <jbrunet@...libre.com>, Samuel Holland <samuel@...lland.org>, Thomas Zimmermann <tzimmermann@...e.de>, Daniel Vetter <daniel@...ll.ch>, Emma Anholt <emma@...olt.net>, David Airlie <airlied@...ux.ie>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Kevin Hilman <khilman@...libre.com>, Neil Armstrong <narmstrong@...libre.com>, Maxime Ripard <mripard@...nel.org> Cc: linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org, Phil Elwell <phil@...pberrypi.com>, Mateusz Kwiatkowski <kfyatek+publicgit@...il.com>, linux-arm-kernel@...ts.infradead.org, Geert Uytterhoeven <geert@...ux-m68k.org>, Dave Stevenson <dave.stevenson@...pberrypi.com>, linux-amlogic@...ts.infradead.org, dri-devel@...ts.freedesktop.org, Dom Cobley <dom@...pberrypi.com>, Noralf Trønnes <noralf@...nnes.org> Subject: Re: [PATCH v1 32/35] drm/sun4i: tv: Convert to the new TV mode property Den 29.07.2022 18.35, skrev Maxime Ripard: > Now that the core can deal fine with analog TV modes, let's convert the > sun4i TV driver to leverage those new features. > > Signed-off-by: Maxime Ripard <maxime@...no.tech> > > diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c b/drivers/gpu/drm/sun4i/sun4i_tv.c > index 74ff5ad6a8b9..bed52423776e 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_tv.c > +++ b/drivers/gpu/drm/sun4i/sun4i_tv.c > @@ -586,8 +524,17 @@ static int sun4i_tv_bind(struct device *dev, struct device *master, > > drm_connector_attach_encoder(&tv->connector, &tv->encoder); > > + ret = drm_mode_create_tv_properties(drm, > + DRM_MODE_TV_NORM_NTSC_M | > + DRM_MODE_TV_NORM_PAL_B, > + 0, NULL); > + if (ret) > + goto err_cleanup_connector; > + Looks like you have forgotten to attach the property? Noralf. > return 0; > > +err_cleanup_connector: > + drm_connector_cleanup(&tv->connector); > err_cleanup_encoder: > drm_encoder_cleanup(&tv->encoder); > err_disable_clk: >
Powered by blists - more mailing lists