linux-kernel - Re: [PATCH] initramfs: mask my_inptr as _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220828231922.38d09ecd@echidna.suse.de>
Date:   Sun, 28 Aug 2022 23:19:22 +0200
From:   David Disseldorp <ddiss@...e.de>
To:     wuchi <wuchi.zero@...il.com>
Cc:     viro@...iv.linux.org.uk, willy@...radead.org, mwilck@...e.com,
        akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] initramfs: mask my_inptr as __initdata

On Sat, 27 Aug 2022 15:11:16 +0800, wuchi wrote:

> As my_inptr is only used in __init function unpack_to_rootfs(),
> mark it as __initdata to allow it be freed after boot.
> 
> Signed-off-by: wuchi <wuchi.zero@...il.com>
> ---
>  init/initramfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/init/initramfs.c b/init/initramfs.c
> index 18229cfe8906..2f5bfb7d7652 100644
> --- a/init/initramfs.c
> +++ b/init/initramfs.c
> @@ -482,7 +482,7 @@ static long __init flush_buffer(void *bufv, unsigned long len)
>  	return origLen;
>  }
>  
> -static unsigned long my_inptr; /* index of next byte to be processed in inbuf */
> +static unsigned long my_inptr __initdata; /* index of next byte to be processed in inbuf */
>  
>  #include <linux/decompress/generic.h>
>  

Looks fine.
Reviewed-by: David Disseldorp <ddiss@...e.de>