linux-kernel - Re: [PATCH] Documentation: fb: udlfb: clean up text and formatting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <637e5934-7dd2-c77e-748d-f8445acff29e@infradead.org>
Date:   Sat, 27 Aug 2022 22:31:59 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Bagas Sanjaya <bagasdotme@...il.com>, linux-kernel@...r.kernel.org
Cc:     Bernie Thompson <bernie@...gable.com>, linux-fbdev@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, Helge Deller <deller@....de>,
        Jonathan Corbet <corbet@....net>, linux-doc@...r.kernel.org
Subject: Re: [PATCH] Documentation: fb: udlfb: clean up text and formatting



On 8/27/22 18:51, Bagas Sanjaya wrote:
> On 8/28/22 02:39, Randy Dunlap wrote:
>> -From the command line, pass options to modprobe
>> -modprobe udlfb fb_defio=0 console=1 shadow=1
>> +From the command line, pass options to modprobe::
>>  
>> -Or modify options on the fly at /sys/module/udlfb/parameters directory via
>> -sudo nano fb_defio
>> -change the parameter in place, and save the file.
>> +  modprobe udlfb fb_defio=0 console=1 shadow=1
>> +
>> +Or modify options on the fly at /sys/module/udlfb/parameters directory via::
>> +
>> +  sudo nano fb_defio
>> +  change the parameter in place, and save the file.
>>  
> 
> Better say "Or change the options on the fly by editing
> /sys/module/udlfb/parameters/fb_defio."
> 
>>  Unplug/replug USB device to apply with new settings
>>  
>> -Or for permanent option, create file like /etc/modprobe.d/udlfb.conf with text
>> -options udlfb fb_defio=0 console=1 shadow=1
>> +Or for permanent options, create a file like /etc/modprobe.d/udlfb.conf
>> +with text::
>> +
>> +  options udlfb fb_defio=0 console=1 shadow=1
> 
> Maybe we can say "Or to apply options permanently, create modprobe configuration
> like /etc/modprobe.d/udlfb.conf with::"

Thanks, I'll send a v2.

-- 
~Randy