linux-kernel - Re: [PATCH v1] drivers/clk/clk: check return value of clk_pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202208291148.JSEXDM4l-lkp@intel.com>
Date:   Mon, 29 Aug 2022 12:02:11 +0800
From:   kernel test robot <lkp@...el.com>
To:     Li Zhong <floridsleeves@...il.com>, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, mturquette@...libre.com, sboyd@...nel.org,
        lily <floridsleeves@...il.com>
Subject: Re: [PATCH v1] drivers/clk/clk: check return value of
 clk_pm_runtime_get()

Hi Li,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on clk/clk-next]
[also build test WARNING on linus/master v6.0-rc3 next-20220826]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Li-Zhong/drivers-clk-clk-check-return-value-of-clk_pm_runtime_get/20220829-042043
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: x86_64-randconfig-m001 (https://download.01.org/0day-ci/archive/20220829/202208291148.JSEXDM4l-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

New smatch warnings:
drivers/clk/clk.c:3014 clk_summary_show_subtree() warn: inconsistent indenting
drivers/clk/clk.c:3016 clk_summary_show_subtree() warn: curly braces intended?

Old smatch warnings:
drivers/clk/clk.c:3802 clk_hw_create_clk() warn: passing zero to 'ERR_CAST'

vim +3014 drivers/clk/clk.c

  3006	
  3007	static void clk_summary_show_subtree(struct seq_file *s, struct clk_core *c,
  3008					     int level)
  3009	{
  3010		struct clk_core *child;
  3011		int ret;
  3012		
  3013		ret = clk_pm_runtime_get(c);
> 3014	    if (ret)
  3015	        return;
> 3016		clk_summary_show_one(s, c, level);
  3017		clk_pm_runtime_put(c);
  3018	
  3019		hlist_for_each_entry(child, &c->children, child_node)
  3020			clk_summary_show_subtree(s, child, level + 1);
  3021	}
  3022	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp