linux-kernel - Re: [PATCH] USB: serial: option: add support for Cinterion MV32-WA/WB RmNet mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 29 Aug 2022 15:36:50 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Slark Xiao <slark_xiao@....com>
Cc:     gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH] USB: serial: option: add support for Cinterion
 MV32-WA/WB RmNet mode

On Wed, Aug 10, 2022 at 11:30:50AM +0800, Slark Xiao wrote:
> We added PIDs for MV32-WA/WB MBIM mode before, now we need to add
> support for RmNet mode.

> Signed-off-by: Slark Xiao <slark_xiao@....com>
> ---
>  drivers/usb/serial/option.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index de59fa919540..63af8b48831a 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -438,6 +438,8 @@ static void option_instat_callback(struct urb *urb);
>  #define CINTERION_PRODUCT_MV31_2_RMNET		0x00b9
>  #define CINTERION_PRODUCT_MV32_WA		0x00f1
>  #define CINTERION_PRODUCT_MV32_WB		0x00f2
> +#define CINTERION_PRODUCT_MV32_WA_RMNET		0x00f3
> +#define CINTERION_PRODUCT_MV32_WB_RMNET		0x00f4
>  
>  /* Olivetti products */
>  #define OLIVETTI_VENDOR_ID			0x0b3c
> @@ -1995,6 +1997,10 @@ static const struct usb_device_id option_ids[] = {
>  	  .driver_info = RSVD(3)},
>  	{ USB_DEVICE_INTERFACE_CLASS(CINTERION_VENDOR_ID, CINTERION_PRODUCT_MV32_WB, 0xff),
>  	  .driver_info = RSVD(3)},
> +	{ USB_DEVICE_INTERFACE_CLASS(CINTERION_VENDOR_ID, CINTERION_PRODUCT_MV32_WA_RMNET, 0xff),
> +	  .driver_info = RSVD(0)},

I moved this entry above CINTERION_PRODUCT_MV32_WB to the keep the
entries sorted.

> +	{ USB_DEVICE_INTERFACE_CLASS(CINTERION_VENDOR_ID, CINTERION_PRODUCT_MV32_WB_RMNET, 0xff),
> +	  .driver_info = RSVD(0)},
>  	{ USB_DEVICE(OLIVETTI_VENDOR_ID, OLIVETTI_PRODUCT_OLICARD100),
>  	  .driver_info = RSVD(4) },
>  	{ USB_DEVICE(OLIVETTI_VENDOR_ID, OLIVETTI_PRODUCT_OLICARD120),

Now applied, thanks.

Johan