linux-kernel - [PATCH v1] linux: imx: imx-scu: increased scu message timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20220829135804.12632-1-oliver.graute@kococonnector.com>
Date:   Mon, 29 Aug 2022 15:58:04 +0200
From:   Oliver Graute <oliver.graute@...oconnector.com>
To:     shawnguo@...nel.org
Cc:     oliver.graute@...oconnector.com, oliver.graute@...il.com,
        Anson.Huang@....com, aisheng.dong@....com,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: [PATCH v1] linux: imx: imx-scu: increased scu message timeout

With MAX_RX_TIMEOUT = 30 ms we observed some wired behavior of
communication to scfw. After increasing the scu message timeout to
arbitrarily MAX_RX_TIMEOUT = 1s these problemes are gone.

a35_clk: failed to get clock rate -22
gpt0_clk: failed to attached the power domain -2
imx-scu scu: RPC send msg timeout
gpt2: failed to power up resource 209 ret -110
imx-scu-clk: probe of gpt2_clk failed with error -110
imx-scu scu: RPC send msg timeout
lpspi0: failed to power off resource 53 ret -110
imx-scu scu: RPC send msg timeout
enet1: failed to power up resource 252 ret -110
imx-scu-clk: probe of enet1_clk failed with error -110
mipi_csi0_core_clk: failed to attached the power domain -2
mipi_csi0_esc_clk: failed to attached the power domain -2
mipi_csi0_i2c0_clk: failed to attached the power domain -2
mipi_csi0_pwm0_clk: failed to attached the power domain -2
lvds0_i2c0_clk: failed to attached the power domain -2
lvds0_i2c1_clk: failed to attached the power domain -2
lvds0_i2c1_clk: failed to get clock rate -22
lvds1_i2c1_clk: failed to attached the power domain -2
lvds1_i2c1_clk: failed to get clock rate -22

Signed-off-by: Oliver Graute <oliver.graute@...oconnector.com>
---
 drivers/firmware/imx/imx-scu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/imx/imx-scu.c b/drivers/firmware/imx/imx-scu.c
index dca79caccd01..cef2bcea61e7 100644
--- a/drivers/firmware/imx/imx-scu.c
+++ b/drivers/firmware/imx/imx-scu.c
@@ -20,7 +20,7 @@
 #include <linux/platform_device.h>
 
 #define SCU_MU_CHAN_NUM		8
-#define MAX_RX_TIMEOUT		(msecs_to_jiffies(30))
+#define MAX_RX_TIMEOUT		(msecs_to_jiffies(1000))
 
 struct imx_sc_chan {
 	struct imx_sc_ipc *sc_ipc;
-- 
2.26.0